Skip to content

Add builder method support for ServiceResolvedConditionKeysTrait #2779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add builder method support for ServiceResolvedConditionKeysTrait #2779

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion ...rc/main/java/software/amazon/smithy/aws/iam/traits/ServiceResolvedConditionKeysTrait.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,10 @@
import software.amazon.smithy.model.shapes.ShapeId;
import software.amazon.smithy.model.traits.StringListTrait;
import software.amazon.smithy.utils.ListUtils;
import software.amazon.smithy.utils.ToSmithyBuilder;

public final class ServiceResolvedConditionKeysTrait extends StringListTrait {
public final class ServiceResolvedConditionKeysTrait extends StringListTrait
implements ToSmithyBuilder<ServiceResolvedConditionKeysTrait> {
public static final ShapeId ID = ShapeId.from("aws.iam#serviceResolvedConditionKeys");
private List<String> resolvedConditionKeys;

Expand Down Expand Up @@ -47,4 +49,20 @@ public Provider() {
super(ID, ServiceResolvedConditionKeysTrait::new);
}
}

public static Builder builder() {
return new Builder();
}

@Override
public Builder toBuilder() {
return builder().sourceLocation(getSourceLocation()).values(getValues());
}

public static final class Builder extends StringListTrait.Builder<ServiceResolvedConditionKeysTrait, Builder> {
@Override
public ServiceResolvedConditionKeysTrait build() {
return new ServiceResolvedConditionKeysTrait(getValues(), getSourceLocation());
}
}
}
13 changes: 13 additions & 0 deletions ...est/java/software/amazon/smithy/aws/iam/traits/ServiceResolvedConditionKeysTraitTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@

import static org.hamcrest.MatcherAssert.assertThat;
import static org.hamcrest.Matchers.equalTo;
import static org.junit.jupiter.api.Assertions.assertEquals;

import org.junit.jupiter.api.Test;
import software.amazon.smithy.model.Model;
Expand All @@ -14,6 +15,18 @@
import software.amazon.smithy.utils.ListUtils;

public class ServiceResolvedConditionKeysTraitTest {

@Test
public void testBuilder() {
ServiceResolvedConditionKeysTrait.Builder builder = ServiceResolvedConditionKeysTrait.builder();
builder.addValue("one");
builder.addValue("two");
ServiceResolvedConditionKeysTrait trait = builder.build();
assertEquals(2, trait.getValues().size());
assertThat(trait.getValues(),
equalTo(ListUtils.of("one", "two")));
}

@Test
public void loadsFromModel() {
Model result = Model.assembler()
Expand Down
Loading