Skip to content

Conversation

@jasgin
Copy link

@jasgin jasgin commented Nov 19, 2025

Background

  • What do these changes do?
  • Why are they important?

The event stream protocol test operations take constrained input, but do not have ValidationException in the error closures. This is causing failures in CI for smithy-lang/smithy-rs#4399.

Testing

  • How did you test these changes?

Tests pass with the changes in place locally.

Links

  • Links to additional context, if necessary
  • Issue #, if applicable (see here for a list of keywords to use for linking issues)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jasgin jasgin requested a review from a team as a code owner November 19, 2025 21:04
@jasgin jasgin requested a review from sugmanue November 19, 2025 21:04
@github-actions
Copy link
Contributor

This pull request does not contain a staged changelog entry. To create one, use the ./.changes/new-change command. For example:

./.changes/new-change --pull-requests "#2861" --type feature --description "Add ValidationException to error closures of operations of event stream"

Make sure that the description is appropriate for a changelog entry and that the proper feature type is used. See ./.changes/README or run ./.changes/new-change -h for more information.

joewyz
joewyz previously approved these changes Nov 19, 2025
@joewyz joewyz self-requested a review November 19, 2025 22:18
@joewyz joewyz dismissed their stale review November 19, 2025 22:18

Need more discussion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants