refactor: generalize caller distribution (workflow-agnostic) #42
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| MODEL=sonnet | ||
| LANGUAGE=日本語 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| PR への自動レビュー（Claude）を有効化します。 | ||
|
There was a problem hiding this comment. ✨ [POSITIVE] 各callerの |
||
|
|
||
| - 動作には org シークレット `ANTHROPIC_API_KEY` がこのリポジトリで利用可能である必要があります（未配布なら安全にスキップ） | ||
|
There was a problem hiding this comment. ℹ️ [LOW] 以前の |
||
| - draft PR は `ready_for_review` まで、fork PR は secret 不在のため、いずれも安全にスキップします | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| # Caller template: Claude Code Review (automatic PR review). | ||
| # Distributed by scripts/distribute-workflow.sh as | ||
| # .github/workflows/claude-code-review.yml in each target repository. | ||
| # The ref / model / language tokens below are substituted at distribution time. | ||
| name: Claude Code Review | ||
|
|
||
| on: | ||
| pull_request: | ||
| types: [opened, reopened, ready_for_review] # no synchronize: avoid re-reviewing every push | ||
|
|
||
| concurrency: | ||
| group: claude-review-${{ github.event.pull_request.number }} | ||
| cancel-in-progress: true | ||
|
|
||
| jobs: | ||
| review: | ||
| uses: smkwlab/.github/.github/workflows/claude-code-review.yml@__REF__ | ||
|
There was a problem hiding this comment. ✨ [POSITIVE] Claude Code Reviewワークフローのcallerテンプレートが適切に定義されています。 |
||
| permissions: | ||
| contents: read | ||
| pull-requests: write | ||
| issues: write | ||
| id-token: write | ||
| secrets: | ||
| anthropic_api_key: ${{ secrets.ANTHROPIC_API_KEY }} | ||
| with: | ||
| model: __MODEL__ | ||
| review_language: __LANGUAGE__ | ||
|
Comment on lines
+26
to
+27
There was a problem hiding this comment. [warning] 旧スクリプトはデフォルトを 同じ問題は 対処案（いずれか）:
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| MODEL=sonnet | ||
| LANGUAGE=日本語 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| `@claude` メンションでの対話・修正依頼を有効化します。 | ||
|
|
||
| - 動作には org シークレット `ANTHROPIC_API_KEY` がこのリポジトリで利用可能である必要があります（未配布なら安全にスキップ） | ||
| - 起動するのは権限保有者（OWNER / MEMBER / COLLABORATOR）のコメントのみです |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| # Caller template: Claude Mention (interactive @claude handler). | ||
| # Distributed by scripts/distribute-workflow.sh as | ||
| # .github/workflows/claude-mention.yml in each target repository. | ||
| # The ref / model / language tokens below are substituted at distribution time. | ||
| name: Claude Mention | ||
|
|
||
| on: | ||
| issue_comment: | ||
| types: [created] | ||
| pull_request_review_comment: | ||
| types: [created] | ||
| issues: | ||
| types: [opened] | ||
|
|
||
| jobs: | ||
| claude: | ||
| # Run only when @claude is mentioned AND the author has repository access | ||
| # (OWNER/MEMBER/COLLABORATOR), so external users cannot trigger a write run. | ||
| if: > | ||
|
There was a problem hiding this comment. ✨ [POSITIVE] Claude Mentionワークフローのcallerテンプレートも適切に定義されています。特に、 |
||
| (github.event_name == 'issue_comment' && contains(github.event.comment.body, '@claude') && contains(fromJSON('["OWNER","MEMBER","COLLABORATOR"]'), github.event.comment.author_association)) || | ||
| (github.event_name == 'pull_request_review_comment' && contains(github.event.comment.body, '@claude') && contains(fromJSON('["OWNER","MEMBER","COLLABORATOR"]'), github.event.comment.author_association)) || | ||
| (github.event_name == 'issues' && contains(github.event.issue.body, '@claude') && contains(fromJSON('["OWNER","MEMBER","COLLABORATOR"]'), github.event.issue.author_association)) | ||
| uses: smkwlab/.github/.github/workflows/claude-mention.yml@__REF__ | ||
| permissions: | ||
| contents: write | ||
| pull-requests: write | ||
| issues: write | ||
| id-token: write | ||
| secrets: | ||
| anthropic_api_key: ${{ secrets.ANTHROPIC_API_KEY }} | ||
| with: | ||
| model: __MODEL__ | ||
| language: __LANGUAGE__ | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✨ [POSITIVE] ワークフロー配布スクリプトの汎用化に伴い、READMEが非常に分かりやすく更新されています。特に、callerテンプレートの表と新しいワークフローを追加する手順は、今後の運用と拡張性を大きく助けるでしょう。