Skip to content

ci: re-review on push (add synchronize)#28

Merged
toshi0806 merged 1 commit into
mainfrom
ci/review-on-synchronize
Jun 10, 2026
Merged

ci: re-review on push (add synchronize)#28
toshi0806 merged 1 commit into
mainfrom
ci/review-on-synchronize

Conversation

@toshi0806

Copy link
Copy Markdown
Member

AI レビューを push のたびに再実行するよう synchronize をトリガに追加(smkwlab/.github#55 に追従)。連続 push 時は concurrency が古い実行をキャンセルします。

Copilot AI review requested due to automatic review settings June 10, 2026 09:04
@toshi0806 toshi0806 merged commit 8bc084c into main Jun 10, 2026
@toshi0806 toshi0806 deleted the ci/review-on-synchronize branch June 10, 2026 09:05

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

この変更は、AIコードレビューのトリガーに synchronize を追加し、プッシュのたびに再レビューが実行されるようにするものです。変更自体はシンプルで意図が明確ですが、1点注意すべき点があります。

on:
pull_request:
types: [opened, reopened, ready_for_review] # no synchronize: avoid re-reviewing every push
types: [opened, reopened, ready_for_review, synchronize] # synchronize: re-review on each push. Drop if cost is a concern.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [MEDIUM] [MEDIUM] concurrencycancel-in-progress 設定の確認が必要です。

synchronize を追加することで、連続プッシュ時に古い実行をキャンセルする動作が期待されていますが、現在の concurrency 設定に cancel-in-progress: true が明示されているか確認してください。この設定がない場合、古い実行はキャンセルされずキューに積まれ続け、コスト増加や意図しない動作につながる可能性があります。

concurrency:
  group: ai-code-review-${{ github.event.pull_request.number }}
  cancel-in-progress: true  # ← これが必要

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants