iface: remove always-Ok Results in consume(). #1093
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They're useless, Ok() was always returned. Additionally, it's misleading to return a Result from the `consume` closure since it implies TX will be canceled on Err which is not the case (the driver implementation can't inspect the result, it just sees a generic `R`, all it can do is pass it through).
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1093 +/- ##
==========================================
- Coverage 80.45% 80.45% -0.01%
==========================================
Files 81 81
Lines 24461 24460 -1
==========================================
- Hits 19681 19680 -1
Misses 4780 4780 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They're useless, Ok() was always returned. Additionally, it's misleading
to return a Result from the
consumeclosure since it implies TX willbe canceled on Err which is not the case (the driver implementation can't inspect the
result, it just sees a generic
R, all it can do is pass it through).