Skip to content

Conversation

@xyzzyz
Copy link

@xyzzyz xyzzyz commented Nov 1, 2025

When reassembling fragmented packet, we currently don't recompute the total length in the IPv4 header. The comment in the code says that we don't really use the header, but this is not actually true: for raw sockets, this will result in the total_length to be equal to the length in the last received fragment. Users of raw sockets typically parse the IP headers, so it is important to set these correctly.

@codecov
Copy link

codecov bot commented Nov 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.55%. Comparing base (39cd44e) to head (fe311b0).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1094      +/-   ##
==========================================
+ Coverage   80.45%   80.55%   +0.09%     
==========================================
  Files          81       81              
  Lines       24461    24463       +2     
==========================================
+ Hits        19681    19705      +24     
+ Misses       4780     4758      -22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant