Set correct packet length after defragmenting a packet #1094
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When reassembling fragmented packet, we currently don't recompute the total length in the IPv4 header. The comment in the code says that we don't really use the header, but this is not actually true: for raw sockets, this will result in the total_length to be equal to the length in the last received fragment. Users of raw sockets typically parse the IP headers, so it is important to set these correctly.