Thomasgorissen/fix mixfix track result codelens#894
Merged
serrynaimo merged 6 commits intomainfrom Apr 19, 2026
Merged
Conversation
rebuildMixfixAppAnno in TypeCheck was producing one payload hole per restructured arg, but the generic ToConcreteNodes instance for App expects exactly two (funcName + args list as a whole). The extra holes caused toNodes to fail with InsufficientHoleFit, so rangeOfNode returned Nothing for any enclosing Directive and the codelens was silently dropped on mixfix call sites. Also reorder the AI tutorials README to put "Composing L4 with AI" first, and point the jl4-web example selector's external button at the VS Code marketplace listing.
The VSCode webview inspector formats structured result values by breaking commas onto indented lines and stripping the outer parens from record values (so `(Foo WITH a = 1, b = 2)` renders as a multi-line block). jl4-web was still displaying them single-line. Port formatResultValue and apply it to both the colorized and uncolorized render paths.
Adopt the structural improvements from the VSCode inspector while keeping jl4-web's existing light theme: - Wrap each file's sections in a .file-group so the "Remove all" button sits alongside a per-file result count. - Merge the chevron toggle and the file/section label into a single button so the whole header row is clickable; hover now highlights the whole section header. - Support ⌘/Ctrl+click on a result's header to reveal the directive in the Monaco editor (wired through a new onRevealSource prop). - Bump the success/failure left border from 2 to 3px to match the VSCode side. Skipped intentionally: VSCode theme variable CSS (jl4-web has its own light theme), the @repo/l4-highlight colorizer swap (Monaco is already loaded here), and the directive-id parser rewrite (jl4-web uses a bare "line:col" id, not the "uri:line:col" form VSCode uses).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.