Skip to content

fix: fix misleading CLI help text #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 18, 2025
Merged

fix: fix misleading CLI help text #76

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c4fbc18
fix: allow older packaging dep
johanneskoester Jul 4, 2025
8d417f0
fix: help messages
johanneskoester Jul 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ version = "1.20.0"
description = "Common functions and classes for Snakemake and its plugins"
readme = "README.md"
requires-python = ">=3.8"
dependencies = ["argparse-dataclass>=2.0.0", "ConfigArgParse>=1.7", "packaging >=25.0,<26.0"]
dependencies = ["argparse-dataclass>=2.0.0", "ConfigArgParse>=1.7", "packaging >=24.0,<26.0"]

[[project.authors]]
name = "Johannes Koester"
Expand Down
4 changes: 2 additions & 2 deletions src/snakemake_interface_common/plugin_registry/plugin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ def support_tagged_values(self) -> bool:
return False

def has_settings_cls(self) -> bool:
"""Determine if a plugin defines custom executor settings"""
"""Determine if a plugin defines custom settings"""
return self.settings_cls is not None

def get_settings_info(self) -> List[Dict[str, Any]]:
Expand Down Expand Up @@ -151,7 +151,7 @@ def register_cli_args(self, argparser: "ArgumentParser") -> None:
self.name, "Fields of ExecutorSettings must have a default value."
)

settings = argparser.add_argument_group(f"{self.name} executor settings")
settings = argparser.add_argument_group(f"{self.name} plugin settings")

for thefield in fields(params):
prefixed_name = self._get_prefixed_name(thefield.name).replace("-", "_")
Expand Down