Implement extern(C) mangling for variables.#214
Open
redstar wants to merge 1 commit intosnazzy-d:masterfrom
Open
Implement extern(C) mangling for variables.#214redstar wants to merge 1 commit intosnazzy-d:masterfrom
redstar wants to merge 1 commit intosnazzy-d:masterfrom
Conversation
extern(C) mangling is useful for interfacing with C. It enables
extern(C) int bar;
to compile.
Contributor
|
Look good overall, however, it doesn't looks like the test is testing anything. |
Contributor
Author
|
A lit test is required to really check this. I still need to figure out how to run lit.... |
Contributor
|
You can find existing lit tests in test/llvm You can run them via make littest |
8c71eeb to
6c2cf7e
Compare
abb159a to
ddd472c
Compare
5027160 to
6d58784
Compare
9fcc9e5 to
a1ef70f
Compare
dc3ea09 to
1f71c2a
Compare
0fb9de0 to
208c449
Compare
f94baa8 to
87a9baf
Compare
cf07b66 to
39f39ba
Compare
4acd1ab to
e854d3d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
extern(C) mangling is useful for interfacing with C. It enables
to compile.