Add Docker support#186
Conversation
| # tcc \ | ||
| # unzip | ||
|
|
||
| ## Switch build dependencies |
There was a problem hiding this comment.
Why not break out to separate Dockerfiles per target?
There was a problem hiding this comment.
That's not a bad idea. My original thought was to specify targets using arguments. But different Dockerfiles per target would be clearer and split out the process to be maintained separately.
When I have some free cycles, I'll redo this PR. Unless someone else beats me to it 😉😂
There was a problem hiding this comment.
I'm not a docker expert, but I think duplicating information into multiple Dockerfiles is not very DRY.
Is there a way to have a common dockerfile for the others to reference?
There was a problem hiding this comment.
I think it is better to keep it in one Dockerfile, that way you can call both jobs, reusing code and decreasing build time.
Correção no src/main.cs, pullrequest snesrev#247 Correção no src/opengl.cs, pullrequest snesrev#270 Correção no src/platform/switch/Makefile, pullrequest snesrev#273 Correção no MakeFile, pullrequest snesrev#276 Correção no src/select_file.c, pullrequest snesrev#292
4 participants
Description
Adding support for setting up build environments with Docker & doing builds using Docker
Currently only targets Linux & maybe Mac. Have not tested for Windows/Switch (There was an unsuccessful attempt. If someone wants to help work this out, feel free. My personal target is Linux :P)
Will this Pull Request break anything?
Nope, just adding a Dockerfile & some changes to the readme. I tested the process using Docker & Podman, it builds without issue.
Suggested Testing Steps
This should be no different than your typical Linux build. Ensure the game runs & things appear normal.