Fixed bug on cursor for copy file screen#292
Open
Jellio320 wants to merge 1 commit into
Open
Conversation
Fixed bug cursor would continue to move past top file after pressing up.
danielsoares02
added a commit
to danielsoares02/zelda3
that referenced
this pull request
Jan 5, 2025
Correção no src/main.cs, pullrequest snesrev#247 Correção no src/opengl.cs, pullrequest snesrev#270 Correção no src/platform/switch/Makefile, pullrequest snesrev#273 Correção no MakeFile, pullrequest snesrev#276 Correção no src/select_file.c, pullrequest snesrev#292
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed bug cursor would continue to move past top file after pressing up.
Description
This PR fixes a very tiny bug unique to this implementation. The fairy cursor on the copy file screen would continue to move up past the top file and jump to various places on the screen. Function originally attempted to check if an unsigned byte was less than zero. Fixed by instead just checking if the signed bit is set.
Will this Pull Request break anything?
No.
Suggested Testing Steps
Move cursor around on the copy file screen.