Changes to snow_erosion=REDEPOSIT #27
Open
bertjebertjek wants to merge 2 commits into
Open
Conversation
… windward vstation, and 2) snow_erosion=REDEPOSIT to redeposit on same slope (before potential redistribution) only for flat field. Before this commit, the eroded snow was both redeposited on the same slope as well as redistributed to the lee slope (in case of snow_redistribution).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changed 1) snow_erosion=REDEPOSIT || FREE to only erode flat field or windward vstation, and 2) snow_erosion=REDEPOSIT to redeposit on same slope (before potential redistribution) only for flat field. Before this commit, the eroded snow was both redeposited on the same slope as well as redistributed to the lee slope (in case of snow_redistribution).
Changed compSnowDrift to only erode windward or flat field in case of
whereas before all aspects were eroded.
For snow_erosion=REDEPOSIT, the redeposition on the same slope now only happens for flat field, and not for all aspects. This changes the behavior on the vslopes significantly. In case of snow_redistribution=True + snow_erosion=REDEPOSIT, the same ErosionMass from the luv slope got both redeposited on the original slope as well as redistributed to the lee slope, which lead to massive snowdepths on all Vslopes.
I still feel snow_erosion=REDISTRIBUTION (or FREE) does not work well with virtual stations when snow_redistribution is True. But that is maybe a combination of settings that should just be avoided.
In the image below, the 4th column shows the implemented changes vs column 3.