Skip to content

Conversation

@snyk-tim
Copy link
Contributor

@snyk-tim snyk-tim commented Oct 16, 2025

Pull Request Submission Checklist

  • Follows CONTRIBUTING guidelines
  • Commit messages
    are release-note ready, emphasizing
    what was changed, not how.
  • Includes detailed description of changes
  • Contains risk assessment (Low | Medium | High)
  • Highlights breaking API changes (if applicable)
  • Links to automated tests covering new functionality
  • Includes manual testing instructions (if necessary)
  • Updates relevant GitBook documentation (PR link: ___)
  • Includes product update to be announced in the next stable release notes

What does this PR do?

Updates the snyk-nuget-plugin which stops misclassifying NX Build projects (project.json) as NuGet projects. When an invalid project.json is found it now throws a NotSupportedEcosystem error.

The cli has been updated to handle this new NotSupportedEcosystem error by skipping over the file and logging a debug message.

NX Build project files have been added to the fixtures to test both snyk test and snyk sbom commands through the integration tests.

How should this be manually tested?

You can see this failing running one of the following command with an old CLI build in the test/acceptance/workspaces/mono-repo-project-manifests-only folder.

snyk test --print-graph --json --all-projects --fail-fast

snyk sbom --format cyclonedx1.5+json --all-projects

What's the product update that needs to be communicated to CLI users?

Stops misclassifying NX Build project.json as a NuGet project.

@snyk-io
Copy link

snyk-io bot commented Oct 16, 2025

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Licenses 0 0 0 0 0 issues
Code Security 0 0 0 0 0 issues
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@snyk-tim snyk-tim force-pushed the feat/update-nuget-plugin-handle-nx-build-projects branch from 8760c13 to eddbcbf Compare October 20, 2025 07:35
@snyk-tim snyk-tim marked this pull request as ready for review October 20, 2025 08:38
@snyk-tim snyk-tim requested review from a team as code owners October 20, 2025 08:38
@snyk-tim snyk-tim force-pushed the feat/update-nuget-plugin-handle-nx-build-projects branch 2 times, most recently from 730dec0 to 1eed504 Compare October 21, 2025 08:27
@snyk-tim snyk-tim force-pushed the feat/update-nuget-plugin-handle-nx-build-projects branch from 1eed504 to ab93f46 Compare October 21, 2025 10:52
@snyk-tim snyk-tim enabled auto-merge October 21, 2025 11:37
@snyk-tim snyk-tim force-pushed the feat/update-nuget-plugin-handle-nx-build-projects branch 2 times, most recently from e088b2c to 28e9707 Compare October 21, 2025 16:17
@snyk-tim snyk-tim force-pushed the feat/update-nuget-plugin-handle-nx-build-projects branch from 28e9707 to ff6860f Compare October 22, 2025 08:27
@snyk-tim snyk-tim merged commit 7697165 into main Oct 22, 2025
8 checks passed
@snyk-tim snyk-tim deleted the feat/update-nuget-plugin-handle-nx-build-projects branch October 22, 2025 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants