Skip to content

chore: add helper to access feature flags #349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 20, 2025
Merged

chore: add helper to access feature flags #349

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 11 additions & 9 deletions pkg/local_workflows/config_utils/feature_flag.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
package config_utils

import (
"net/http"

"github.com/snyk/go-application-framework/internal/api"
"github.com/snyk/go-application-framework/pkg/configuration"
"github.com/snyk/go-application-framework/pkg/workflow"
Expand All @@ -12,19 +14,19 @@ func AddFeatureFlagToConfig(engine workflow.Engine, configKey string, featureFla
callback := func(existingValue interface{}) (interface{}, error) {
if existingValue == nil {
httpClient := engine.GetNetworkAccess().GetHttpClient()
logger := engine.GetLogger()
url := config.GetString(configuration.API_URL)
org := config.GetString(configuration.ORGANIZATION)
apiClient := api.NewApi(url, httpClient)
result, err := apiClient.GetFeatureFlag(featureFlagName, org)
if err != nil {
logger.Printf("Failed to determine feature flag \"%s\" for org \"%s\": %s", featureFlagName, org, err)
}
return result, nil
return GetFeatureFlagValue(featureFlagName, config, httpClient)
} else {
return existingValue, nil
}
}

config.AddDefaultValue(configKey, callback)
}

func GetFeatureFlagValue(featureFlagName string, config configuration.Configuration, httpClient *http.Client) (bool, error) {
url := config.GetString(configuration.API_URL)
org := config.GetString(configuration.ORGANIZATION)
apiClient := api.NewApi(url, httpClient)
result, err := apiClient.GetFeatureFlag(featureFlagName, org)
return result, err
}