Repository navigation
Make NaN-to-0 postprocessing explicit and document edge case (#39) - #52
Open
Mustaphayinka wants to merge 1 commit into
Open
Mustaphayinka wants to merge 1 commit into
Mustaphayinka wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #39
As noted in the issue thread, this preserves the existing NaN→0 behavior so results that depend on it remain reproducible. It also makes that behavior explicit by using nan=0.0 rather than the previous np.nan_to_num(x, -1), which silently relied on the default fill value despite appearing to specify -1.
It also adds a README note about the NaN/0 collision issue in ACSHealthInsurance, which @AndreFCruz identified in the issue thread.