Skip to content

Suppress error events. #280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Suppress error events. #280

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ module.exports.fake_response = function fake_response(req, res) {
}
r.push('');
r.push('');
res.on('error', () => {});
Copy link
Preview

Copilot AI Aug 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Silently suppressing all errors with an empty handler is risky and makes debugging difficult. Consider logging the error or handling specific error types appropriately.

Suggested change
res.on('error', () => {});
res.on('error', (err) => {
console.error('Error in fake_response res:', err);
});

Copilot uses AI. Check for mistakes.

Copy link
Preview

Copilot AI Aug 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The empty error handler provides no context about what errors are being suppressed. At minimum, consider adding a comment explaining why errors are being ignored or log them for debugging purposes.

Suggested change
res.on('error', () => {});
res.on('error', (err) => {
// Log the error for debugging purposes
console.error('Error in fake_response:', err);
});

Copilot uses AI. Check for mistakes.

try {
res.write(r.join('\r\n'));
} catch (x) {
Expand Down