-
Notifications
You must be signed in to change notification settings - Fork 20
[김현지] 피그마 요구사항 반영 (post 생성 후 조회, comment 추가 및 조회) #238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kimhji
wants to merge
23
commits into
softeerbootcamp-7th:kimhji
Choose a base branch
from
kimhji:feat_extra2
base: kimhji
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Feat extra1
- router의 route input을 prefix 방식으로 탐색하도록 변경 - static 파일과 사용자가 등록해서 따로 저장해둔 이미지를 처리하는 방식을 분리하기 위해 api 추가
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
구현
post, author profile 이미지 불러와서 표시하기
댓글 반영
좋아요 반영
내 정보 수정(닉네임, 패스워드)
고민한 점
이미지 로드 방식
router 내에 path 파라미터를 넣어서 api를 구현하려니, routing 방식이 모든 path에 딱 들어맞아야 해당 등록 함수를 찾는 기존 방식의 문제점을 알 수 있었습니다.
이를 해결하기 위해, route 해서 path를 따라가는 과정에서 다음 routeNode를 찾을 수 없다면 지금까지 따라갔던 해당 노드에서 처리를 진행하는 로직으로 prefix처리 했습니다.