-
Notifications
You must be signed in to change notification settings - Fork 20
[장익환] WAS 과제 7단계 - 이미지 업로드 구현 #243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
JangIkhwan
wants to merge
25
commits into
softeerbootcamp-7th:JangIkhwan
Choose a base branch
from
JangIkhwan:pr/260115
base: JangIkhwan
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 이미지가 없으면 예외 발생 - 이미지를 로컬에 저장
- uri가 정확히 일치할 때 핸들러를 매칭하는 SimpleRouting 구현 - path variable을 고려해서 핸들러와 uri를 매칭할 때 사용하는 PathVariableRouting 구현
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
완료 작업 목록
주요 고민과 해결 과정
Routing인터페이스를 구현했습니다.Routing인터페이스는 요청의 path가 라우팅할 핸들러의 url이 지원하는지 확인하고, 메서드를 확인한 후에 핸들러를 반환하기 위해서 사용합니다.PathVariableRouting를 구현했습니다. 이 클래스는 요청 path를 처리할 수 있는지 여부를 정규식으로 검사하고, path variable을 추출하여서 request에 저장합니다.RequestHandler의resolveHandler()함수는 이와 같은Routing구현체를 리스트에 담아서 매 요청마다 알맞은Handler를 찾습니다.