refactor: fix verbose env var bug and simplify codebase#66
Open
KyleCB wants to merge 1 commit into
Open
Conversation
Co-authored-by: Claude Sonnet 4.6 <no-reply@softleader.com.tw>
KyleCB
force-pushed
the
refactor/simplify-and-fix-code-quality
branch
from
752e26f to
afef5f2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a bug where
NewVerbose()readsBPL_JAVA_NMT_ENABLEDinstead ofBP_LOG_LEVEL, causingBP_LOG_LEVEL=DEBUGto have no effect at startup.Also includes several cleanups found during code review:
calc/jvm_cacerts.go: replaceisFileExist(TOCTOU + silent error discard) with directos.Opencalc/java_tool_options.go: fix option deduplication to use exact token match instead of substringcalc/calculator.go:buildHelpers()now conditionally insertsOpenSSLCertificateLoaderandNMTinstead of constructing them unconditionally and then deletingboot/spring_optimizer.go: remove single-entryinOrder/map dispatch, callWebApplicationType.Execute()directly