feat: Make std functions more generic #1723
Conversation
|
pkg.pr.new packages benchmark commit |
iwoplaza
requested review from
aleksanderkatan,
reczkok,
lursz and
cieplypolar
There was a problem hiding this comment.
wgsl.MatchingBoolInstance<T> can also simplify select signature
|
|
||
| const cpuLt = <T extends AnyNumericVecInstance>(lhs: T, rhs: T) => | ||
| VectorOps.lt[lhs.kind](lhs, rhs); | ||
| function cpuLt(lhs: number, rhs: number): boolean; |
There was a problem hiding this comment.
At some point we decided that if a plain js operator works, then we do not write overloads for std operators so as not to encourage users to complicate their code.
I assume we withdraw that decision to allow for overloaded functions, right? If so, the JSDocs would need updating
|
|
||
| const cpuLt = <T extends AnyNumericVecInstance>(lhs: T, rhs: T) => | ||
| VectorOps.lt[lhs.kind](lhs, rhs); | ||
| function cpuLt(lhs: number, rhs: number): boolean; |
There was a problem hiding this comment.
I am not convinced about these new overloads. The following now becomes type safe, and it will generate invalid wgsl. It would be fine if we handled mixed comparisons though. Maybe we could make unify cast numbers to vectors by wrapping them?
function cmpLt(a: number | AnyNumericVecInstance, b: number | AnyNumericVecInstance) {
"kernel";
return lt(a, b);
}
cmpLt(3, vec2f());| returnType: correspondingBooleanVectorSchema(uargs[0]), | ||
| }); | ||
| }, | ||
| normalImpl: <T extends AnyNumericVecInstance>(lhs: T, rhs: T) => |
There was a problem hiding this comment.
This function's interface is now inconsistent with other boolean functions
| returnType: correspondingBooleanVectorSchema(uargs[0]), | ||
| }); | ||
| }, | ||
| normalImpl: <T extends AnyNumericVecInstance>(lhs: T, rhs: T) => |
No description provided.