fix: Console.log in drawindexed #1771
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes console.log functionality for the drawIndexed method in render pipelines, ensuring that logging works correctly when drawing indexed geometry.
- Adds logging support to
drawIndexedmethod by integrating log resource handling - Adds a new "Draw indexed" test case to verify console.log functionality with indexed drawing
- Refactors shader definitions and removes unused test case to improve test organization
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/typegpu/src/core/pipeline/renderPipeline.ts | Integrates log resources handling into the drawIndexed method |
| apps/typegpu-docs/src/examples/tests/log-test/index.ts | Adds "Draw indexed" test case and refactors shader definitions |
| packages/typegpu/tests/examples/individual/log-test.test.ts | Updates expected test count and adds corresponding shader code for the new test |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
aleksanderkatan
requested review from
cieplypolar,
iwoplaza,
lursz and
reczkok
|
pkg.pr.new packages benchmark commit |
cieplypolar
approved these changes
Oct 9, 2025
Comment on lines
-210
to
-221
| 'Too much data': { | ||
| onButtonClick: () => { | ||
| try { | ||
| prepareDispatch(root, () => { | ||
| 'kernel'; | ||
| console.log(d.mat4x4f(), d.mat4x4f(), 1); | ||
| }).dispatch(); | ||
| } catch (err) { | ||
| console.log(err); | ||
| } | ||
| }, | ||
| }, |
There was a problem hiding this comment.
What's the reason for deleting this test?
There was a problem hiding this comment.
It does not need to use the GPU, so no need to keep it in an example. The same test already appears in unit tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.