Feature: Add flash message when LiveView crashes#923
Merged
Conversation
hhubert6
reviewed
Feb 17, 2026
Contributor
hhubert6
left a comment
hhubert6
left a comment
There was a problem hiding this comment.
I think it'd be much nicer to redirect to crashed component on the same page instead of opening a new one. Or maybe adding two buttons to give the user a choice. What do you think?
lib/live_debugger/app/debugger/callback_tracing/web/hooks/filter_new_traces.ex
Outdated
Show resolved
Hide resolved
lib/live_debugger/app/debugger/callback_tracing/web/hooks/filter_new_traces.ex
Show resolved
Hide resolved
Contributor
Author
You are right. I change it to redirect to the same page. I think two redirects is too much for this flash message. |
kraleppa
reviewed
Feb 19, 2026
lib/live_debugger/app/debugger/callback_tracing/web/hooks/filter_new_traces.ex
Show resolved
Hide resolved
hhubert6
approved these changes
Feb 19, 2026
kraleppa
approved these changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.