Migrate remaining node inspector e2e tests to playwright#953
Merged
Conversation
hhubert6
force-pushed
the
rewrite-e2e-node-inspector-tests-to-playwright
branch
from
57eaf29 to
b40107f
Compare
There was a problem hiding this comment.
Pull request overview
Migrates the remaining Node Inspector end-to-end coverage from the legacy Elixir-based e2e suite to the Playwright e2e suite, consolidating Node Inspector behavior tests under the JS/TS runner.
Changes:
- Removed the legacy
test/e2e/node_inspector_test.exsNode Inspector e2e module. - Added/migrated Node Inspector scenarios into
e2e/tests/node-inspector.spec.ts(filters, search, copy, dead view mode, node highlighting).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| test/e2e/node_inspector_test.exs | Deletes the legacy Node Inspector e2e tests to complete the migration. |
| e2e/tests/node-inspector.spec.ts | Adds Playwright equivalents for Node Inspector behaviors (filters/search/copy/highlight/dead-view mode). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.