Skip to content

Refacotr/decode audio data removes file prefix#268

Merged
maciejmakowski2003 merged 1 commit intofeat/analyser-nodefrom
refacotr/decode-audio-data-removes-file-prefix
Jan 23, 2025
Merged

Refacotr/decode audio data removes file prefix#268
maciejmakowski2003 merged 1 commit intofeat/analyser-nodefrom
refacotr/decode-audio-data-removes-file-prefix

Conversation

@maciejmakowski2003
Copy link
Collaborator

Closes #257

Introduced changes

  • Added removing file:// prefix in decodeAudioDataSource method on ts side

Checklist

  • Linked relevant issue
  • Updated relevant documentation
  • Added/Conducted relevant tests
  • Performed self-review of the code

@maciejmakowski2003 maciejmakowski2003 self-assigned this Jan 22, 2025
@maciejmakowski2003 maciejmakowski2003 changed the base branch from main to feat/analyser-node January 22, 2025 15:39
Copy link
Member

@michalsek michalsek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@maciejmakowski2003 maciejmakowski2003 merged commit 5dc787f into feat/analyser-node Jan 23, 2025
@maciejmakowski2003 maciejmakowski2003 deleted the refacotr/decode-audio-data-removes-file-prefix branch January 23, 2025 14:38
maciejmakowski2003 added a commit that referenced this pull request Jan 23, 2025
* feat: added ts interface for AnalyserNode

* refactor: refactored AudioNode

* refactor: moved Constants.h to core

* feat: added AnalyserNode core class

* feat: added HostObject for AnalyserNode

* feat: added host functions caching

* refactor: removed unused components and moved common files to common example folders and format

* fix: fixed metronome, removed unused files and moved common files

* fix: back to previous version of hihat

* fix: fixed start/stop mechanism bug

* feat: added analyser constants to Constants.h

* fix: fixed The global process.env.EXPO_OS is not defined warning in fabric-example

* feat: added createAnalyser to is interfaces

* refactor: refactored AnalyserNode creation and itself

* feat: implemented getFloatTimeDomainData and getByteTimeDomainData

* fix: fixed Analyser HostObject exported functions

* fix: prettier fixes and fixed AnalyserNode props modifiability

* feat: added AudioVisualizer example for testing and fixed eslint config

* fix: fixed AnalyserNode writing to inputBuffer

* feat: added ts error handling

* feat: added utils for float to uint8 conversion

* feat: added linear to decibels conversion

* feat: implemented AnalyserNode

* feat: implemented doFFT in FFTFrame

* ci: yarn format and small fixes

* refactor: refactored FFTFrame, added setups caching

* fix: fixed variables names in FFTFrame

* docs: updated Web Audio API coverage

* feat: added very first version of AudioVisualizer example

* fix: small prettier and yarn format fixes

* refactor: refactored example

* fix: small fixes

* feat: added comments to AnalyserNode impl

* fix: fixed frequencyBinCount prop

* fix: removed log

* feat: boost AudioVisualizer

* fix: fixed TimeChartLine size

* refactor: added removing file:// in decodeAudioSource method (#268)

Co-authored-by: Maciej Makowski <maciej.makowski2608@gmail.com>

* feat: some changes to the audio visualizer example (#270)

* feat: some changes to the audio visualizer example

* Update apps/common-app/src/examples/AudioVisualizer/Charts.tsx

* refactor: refactored AudioVisualizer example

* fix: fixed error handling

* refactor: back to useState

---------

Co-authored-by: Maciej Makowski <maciej.makowski@swmansion.com>
Co-authored-by: Maciej Makowski <maciej.makowski2608@gmail.com>
Co-authored-by: Michał Sęk <michal.sek@swmansion.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

decodeAudioData should remove "file://" internaly if required

2 participants