Refacotr/decode audio data removes file prefix#268
Merged
maciejmakowski2003 merged 1 commit intofeat/analyser-nodefrom Jan 23, 2025
Merged
Conversation
maciejmakowski2003
added a commit
that referenced
this pull request
Jan 23, 2025
* feat: added ts interface for AnalyserNode * refactor: refactored AudioNode * refactor: moved Constants.h to core * feat: added AnalyserNode core class * feat: added HostObject for AnalyserNode * feat: added host functions caching * refactor: removed unused components and moved common files to common example folders and format * fix: fixed metronome, removed unused files and moved common files * fix: back to previous version of hihat * fix: fixed start/stop mechanism bug * feat: added analyser constants to Constants.h * fix: fixed The global process.env.EXPO_OS is not defined warning in fabric-example * feat: added createAnalyser to is interfaces * refactor: refactored AnalyserNode creation and itself * feat: implemented getFloatTimeDomainData and getByteTimeDomainData * fix: fixed Analyser HostObject exported functions * fix: prettier fixes and fixed AnalyserNode props modifiability * feat: added AudioVisualizer example for testing and fixed eslint config * fix: fixed AnalyserNode writing to inputBuffer * feat: added ts error handling * feat: added utils for float to uint8 conversion * feat: added linear to decibels conversion * feat: implemented AnalyserNode * feat: implemented doFFT in FFTFrame * ci: yarn format and small fixes * refactor: refactored FFTFrame, added setups caching * fix: fixed variables names in FFTFrame * docs: updated Web Audio API coverage * feat: added very first version of AudioVisualizer example * fix: small prettier and yarn format fixes * refactor: refactored example * fix: small fixes * feat: added comments to AnalyserNode impl * fix: fixed frequencyBinCount prop * fix: removed log * feat: boost AudioVisualizer * fix: fixed TimeChartLine size * refactor: added removing file:// in decodeAudioSource method (#268) Co-authored-by: Maciej Makowski <maciej.makowski2608@gmail.com> * feat: some changes to the audio visualizer example (#270) * feat: some changes to the audio visualizer example * Update apps/common-app/src/examples/AudioVisualizer/Charts.tsx * refactor: refactored AudioVisualizer example * fix: fixed error handling * refactor: back to useState --------- Co-authored-by: Maciej Makowski <maciej.makowski@swmansion.com> Co-authored-by: Maciej Makowski <maciej.makowski2608@gmail.com> Co-authored-by: Michał Sęk <michal.sek@swmansion.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #257
Introduced changes
file://prefix indecodeAudioDataSourcemethod on ts sideChecklist