Skip to content

Conversation

@vltkv
Copy link
Contributor

@vltkv vltkv commented Sep 24, 2025

Closes RNAA-163 #667

⚠️ Breaking changes ⚠️

  • Unified decoding methods in BaseAudioContext into a single method with overloads.

Introduced changes

  • Extracted AudioDecoder into a separate, independent module.

Checklist

  • Linked relevant issue
  • Updated relevant documentation
  • Added/Conducted relevant tests
  • Performed self-review of the code
  • Updated Web Audio API coverage
  • Added support for web

@vltkv vltkv added documentation Improvements or additions to documentation refactoring breaking-change labels Sep 25, 2025
@vltkv vltkv marked this pull request as ready for review September 25, 2025 16:24
@vltkv vltkv changed the title Audio decoding module [blocked] Audio decoding module Sep 25, 2025
@vltkv vltkv marked this pull request as draft September 26, 2025 14:50
@vltkv vltkv changed the title [blocked] Audio decoding module Audio decoding module Sep 26, 2025
@vltkv vltkv added the feature New feature label Sep 29, 2025
@vltkv vltkv changed the title Audio decoding module [blocked] Audio decoding module Sep 30, 2025
@vltkv vltkv marked this pull request as ready for review September 30, 2025 16:31
Copy link
Collaborator

@maciejmakowski2003 maciejmakowski2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing piece of work. well done!!!

Copy link
Member

@michalsek michalsek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! one nit, one question :)

@vltkv vltkv force-pushed the audio-decoding-module branch from 49425db to cdcbe02 Compare October 6, 2025 18:00
@vltkv vltkv force-pushed the audio-decoding-module branch from 8ce0d4f to 6f8af7a Compare October 6, 2025 18:21
@vltkv vltkv merged commit 96a5bcd into main Oct 6, 2025
3 checks passed
@vltkv vltkv deleted the audio-decoding-module branch October 7, 2025 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking-change documentation Improvements or additions to documentation feature New feature refactoring

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants