test: tests for stereo panner #714
Merged
+235
−68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maciejmakowski2003
requested review from
poneciak57,
michalsek,
vltkv and
miloszwielgus
poneciak57
approved these changes
Oct 6, 2025
packages/react-native-audio-api/common/cpp/audioapi/core/effects/StereoPannerNode.cpp
Show resolved
Hide resolved
packages/react-native-audio-api/common/cpp/audioapi/core/AudioNode.cpp
Outdated
Show resolved
Hide resolved
michalsek
approved these changes
Oct 6, 2025
added 2 commits
October 6, 2025 15:26
vltkv
pushed a commit
that referenced
this pull request
Oct 6, 2025
* test: tests for stereo panner * refactor: aligned processNode to web audio api spec and fixed sterao panner * test: fixed tests after changing StereoPannerNode implementation * ci: yarn format * fix: nitpick * fix: lint --------- Co-authored-by: maciejmakowski2003 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes RNAA-204
Closes RNAA-216
Introduced changes
processNodewith web audio api spec. currently it is able to processAudioBuswith different number of channels than returned oneChecklist