Skip to content

fix: calculate array length in bytes instead of elements count #978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maciejmakowski2003 merged 2 commits into from
Mar 10, 2026
Merged

fix: calculate array length in bytes instead of elements count #978

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e14ac7e
fix: calculate array length in bytes instead of elements count
maciejmakowski2003 Mar 9, 2026
6ecfcf0
fix: removed comment
maciejmakowski2003 Mar 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/fabric-example/ios/Podfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2588,7 +2588,7 @@ SPEC CHECKSUMS:
ReactCodegen: f66521b131699d6af0790f10653933b3f1f79a6f
ReactCommon: 07572bf9e687c8a52fbe4a3641e9e3a1a477c78e
ReactNativeDependencies: 3467a1fea6f7a524df13b30430bebcc254d9aee2
RNAudioAPI: cb97b644449ba63f7ae31c02f73e9cf1ab8fd259
RNAudioAPI: fa5c075d2fcdb1ad9a695754b38f07c8c3074396
RNGestureHandler: 07de6f059e0ee5744ae9a56feb07ee345338cc31
RNReanimated: d75c81956bf7531fe08ba4390149002ab8bdd127
RNScreens: 6cb648bdad8fe9bee9259fe144df95b6d1d5b707
Expand Down
2 changes: 1 addition & 1 deletion packages/react-native-audio-api/common/cpp/audioapi/HostObjects/AudioParamHostObject.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ JSI_HOST_FUNCTION_IMPL(AudioParamHostObject, setValueCurveAtTime) {
auto arrayBuffer =
args[0].getObject(runtime).getPropertyAsObject(runtime, "buffer").getArrayBuffer(runtime);
auto rawValues = reinterpret_cast<float *>(arrayBuffer.data(runtime));
auto length = static_cast<int>(arrayBuffer.size(runtime));
auto length = static_cast<int>(arrayBuffer.size(runtime) / sizeof(float));
auto values = std::make_shared<AudioArray>(rawValues, length);

auto event = [param = param_,
Expand Down
2 changes: 1 addition & 1 deletion ...ges/react-native-audio-api/common/cpp/audioapi/HostObjects/BaseAudioContextHostObject.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,7 +263,7 @@ JSI_HOST_FUNCTION_IMPL(BaseAudioContextHostObject, createPeriodicWave) {
auto arrayBufferReal =
args[0].getObject(runtime).getPropertyAsObject(runtime, "buffer").getArrayBuffer(runtime);
auto real = reinterpret_cast<float *>(arrayBufferReal.data(runtime));
auto length = static_cast<int>(arrayBufferReal.size(runtime));
auto length = static_cast<int>(arrayBufferReal.size(runtime) / sizeof(float));

auto arrayBufferImag =
args[1].getObject(runtime).getPropertyAsObject(runtime, "buffer").getArrayBuffer(runtime);
Expand Down
4 changes: 2 additions & 2 deletions ...eact-native-audio-api/common/cpp/audioapi/HostObjects/analysis/AnalyserNodeHostObject.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ JSI_HOST_FUNCTION_IMPL(AnalyserNodeHostObject, getFloatFrequencyData) {
auto arrayBuffer =
args[0].getObject(runtime).getPropertyAsObject(runtime, "buffer").getArrayBuffer(runtime);
auto data = reinterpret_cast<float *>(arrayBuffer.data(runtime));
auto length = static_cast<int>(arrayBuffer.size(runtime));
auto length = static_cast<int>(arrayBuffer.size(runtime) / sizeof(float));

auto analyserNode = std::static_pointer_cast<AnalyserNode>(node_);
analyserNode->getFloatFrequencyData(data, length);
Expand All @@ -104,7 +104,7 @@ JSI_HOST_FUNCTION_IMPL(AnalyserNodeHostObject, getFloatTimeDomainData) {
auto arrayBuffer =
args[0].getObject(runtime).getPropertyAsObject(runtime, "buffer").getArrayBuffer(runtime);
auto data = reinterpret_cast<float *>(arrayBuffer.data(runtime));
auto length = static_cast<int>(arrayBuffer.size(runtime));
auto length = static_cast<int>(arrayBuffer.size(runtime) / sizeof(float));

auto analyserNode = std::static_pointer_cast<AnalyserNode>(node_);
analyserNode->getFloatTimeDomainData(data, length);
Expand Down
3 changes: 1 addition & 2 deletions ...t-native-audio-api/common/cpp/audioapi/HostObjects/effects/BiquadFilterNodeHostObject.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,8 +68,7 @@ JSI_HOST_FUNCTION_IMPL(BiquadFilterNodeHostObject, getFrequencyResponse) {
auto arrayBufferFrequency =
args[0].getObject(runtime).getPropertyAsObject(runtime, "buffer").getArrayBuffer(runtime);
auto frequencyArray = reinterpret_cast<float *>(arrayBufferFrequency.data(runtime));
// arrayBufferFrequency is Float32Array from JS and size is in bytes thus hardcoded division by 4
auto length = static_cast<size_t>(arrayBufferFrequency.size(runtime) / 4);
auto length = static_cast<size_t>(arrayBufferFrequency.size(runtime) / sizeof(float));

auto arrayBufferMag =
args[1].getObject(runtime).getPropertyAsObject(runtime, "buffer").getArrayBuffer(runtime);
Expand Down
2 changes: 1 addition & 1 deletion ...eact-native-audio-api/common/cpp/audioapi/HostObjects/effects/IIRFilterNodeHostObject.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ JSI_HOST_FUNCTION_IMPL(IIRFilterNodeHostObject, getFrequencyResponse) {
auto arrayBufferFrequency =
args[0].getObject(runtime).getPropertyAsObject(runtime, "buffer").getArrayBuffer(runtime);
auto frequencyArray = reinterpret_cast<float *>(arrayBufferFrequency.data(runtime));
auto length = static_cast<size_t>(arrayBufferFrequency.size(runtime));
auto length = static_cast<size_t>(arrayBufferFrequency.size(runtime) / sizeof(float));

auto arrayBufferMag =
args[1].getObject(runtime).getPropertyAsObject(runtime, "buffer").getArrayBuffer(runtime);
Expand Down