Skip to content

fix(iOS): body tag handling crash #480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
szydlovsky merged 1 commit into from
Mar 12, 2026
Merged

fix(iOS): body tag handling crash #480

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 18 additions & 12 deletions ios/inputParser/InputParser.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -772,18 +772,24 @@ - (NSString *_Nullable)initiallyProcessHtml:(NSString *_Nonnull)html {
if (normalized != nil) {
fixedHtml = normalized;
}
} else {
// in other case we are most likely working with some external html - try
// getting the styles from between body tags
NSRange openingBodyRange = [htmlWithoutSpaces rangeOfString:@"<body>"];
NSRange closingBodyRange = [htmlWithoutSpaces rangeOfString:@"</body>"];

if (openingBodyRange.length != 0 && closingBodyRange.length != 0) {
NSInteger newStart = openingBodyRange.location + 7;
NSInteger newEnd = closingBodyRange.location - 1;
fixedHtml = [htmlWithoutSpaces
substringWithRange:NSMakeRange(newStart, newEnd - newStart + 1)];
}
}

// Additionally, try getting the content from between body tags if there are
// some:

// Firstly make sure there are no newlines between them.
fixedHtml = [fixedHtml stringByReplacingOccurrencesOfString:@"<body>\n"
withString:@"<body>"];
fixedHtml = [fixedHtml stringByReplacingOccurrencesOfString:@"\n</body>"
withString:@"</body>"];
// Then, if there actually are body tags, use the content between them.
NSRange openingBodyRange = [htmlWithoutSpaces rangeOfString:@"<body>"];
NSRange closingBodyRange = [htmlWithoutSpaces rangeOfString:@"</body>"];
if (openingBodyRange.length != 0 && closingBodyRange.length != 0) {
NSInteger newStart = openingBodyRange.location + 6;
NSInteger newEnd = closingBodyRange.location - 1;
fixedHtml = [htmlWithoutSpaces
substringWithRange:NSMakeRange(newStart, newEnd - newStart + 1)];
}
}

Expand Down
Loading