Conversation
pkaramon
force-pushed
the
@pkaramon/web-setup
branch
from
959e349 to
a3444c5
Compare
…tProps per platform
pkaramon
force-pushed
the
@pkaramon/web-setup
branch
from
a3444c5 to
c9d4f52
Compare
| EnrichedTextInputInstance, | ||
| } from '../types'; | ||
|
|
||
| export interface EnrichedTextInputProps extends BaseEnrichedTextInputProps {} |
There was a problem hiding this comment.
I will try to keep the types as close as possible between native and web, but I think we will have to make at least so tiny modifications for example the style?: ViewStyle | TextStyle will need changing on web to CSSProperties.
There was a problem hiding this comment.
We can have only definition of types and they have to be exactly the same for both plaforms (even if some props on one platform will be no-op)
| "!src/web", | ||
| "!src/index.tsx", | ||
| "!lib/module/web", | ||
| "!lib/module/index.js", | ||
| "!lib/module/index.js.map", | ||
| "!lib/typescript/src/web", | ||
| "!lib/typescript/src/index.d.ts", | ||
| "!lib/typescript/src/index.d.ts.map", |
There was a problem hiding this comment.
I think it would be a good idea to keep the web code hidden until it's at least semi-functional. @exploIF @kacperzolkiewski curious what do you think?
There was a problem hiding this comment.
Sounds good to me!
But it is a little inconsistent to me that we point to excluded files here:
"exports": {
".": {
"react-native": {
"types": "./lib/typescript/src/index.native.d.ts",
"default": "./lib/module/index.native.js"
},
"types": "./lib/typescript/src/index.d.ts",
"default": "./lib/module/index.js"
},
exploIF
left a comment
exploIF
left a comment
There was a problem hiding this comment.
This looks really good! Couple tiny comments and we should be ready to go
| EnrichedTextInputInstance, | ||
| } from '../types'; | ||
|
|
||
| export interface EnrichedTextInputProps extends BaseEnrichedTextInputProps {} |
There was a problem hiding this comment.
We can have only definition of types and they have to be exactly the same for both plaforms (even if some props on one platform will be no-op)
| */ | ||
| useHtmlNormalizer?: boolean; | ||
| } | ||
| export interface EnrichedTextInputProps extends BaseEnrichedTextInputProps {} |
There was a problem hiding this comment.
I think it's redundant. We should have single types definition (but some props can be no-op)
| @@ -1,4 +1,5 @@ | |||
| export * from './EnrichedTextInput'; | |||
There was a problem hiding this comment.
Until we don't have fully functional web, I would keep mobile implementation in index file and web implementation inside index.web. Once web is ready to be published we will rename it to index and index.native. I think it's more safe, I remember that some setups might fail if there is no regular index file.
3 participants
Summary
Explain the motivation for making this change: here are some points to help you:
EnrichedTextInputstub to unblock web integration work.EnrichedTextInputfor the webindex.native.tsxentrypoint for android/ios,index.tsxentrypoint for the webTest Plan
Screenshots / Videos