Skip to content

nitpick pickfirst refactor #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
radoslawrolka wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

nitpick pickfirst refactor #213

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ff919ca
Add pickfirst if package is present
radoslawrolka Jan 14, 2026
dc17b79
Remove arch
radoslawrolka Jan 14, 2026
8f592e5
Update packages/gradle-client/rnrepo-plugin/src/main/kotlin/org/rnrep…
radoslawrolka Jan 15, 2026
30c0065
lint
radoslawrolka Jan 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 9 additions & 10 deletions ...gradle-client/rnrepo-plugin/src/main/kotlin/org/rnrepo/tools/prebuilds/PrebuildsPlugin.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ class PrebuildsPlugin : Plugin<Project> {
}

// Configure pickFirsts for packages with native libraries that may have duplicates
configurePickFirsts(project, extension.supportedPackages)
configurePickFirsts(project, extension.projectPackages)

// Add dependency on generating codegen schema for each library so that task is not dropped
extension.supportedPackages.forEach { packageItem ->
Expand Down Expand Up @@ -195,31 +195,30 @@ class PrebuildsPlugin : Plugin<Project> {
*/
private fun configurePickFirsts(
project: Project,
supportedPackages: Set<PackageItem>,
projectPackages: Set<PackageItem>,
) {
val prebuiltSoProvidersPackageAndLibName =
mapOf(
"react-native-worklets" to "libworklets.so",
"react-native-nitro-modules" to "libNitroModules.so",
)
val architectures = listOf("arm64-v8a", "armeabi-v7a", "x86", "x86_64")
val androidExtension = project.extensions.getByName("android") as? BaseExtension
if (androidExtension == null) {
logger.warn("Android extension not found in project ${project.name}, cannot configure pickFirsts.")
return
}

prebuiltSoProvidersPackageAndLibName.forEach { (prebuiltSoProvidersPackageName, nativeLibName) ->
val isPrebuiltSoProvidersPackageSupported = supportedPackages.any { it.name == prebuiltSoProvidersPackageName }
val isPrebuiltSoProvidersPackageSupported = projectPackages.any { it.name == prebuiltSoProvidersPackageName }
if (!isPrebuiltSoProvidersPackageSupported) {
logger.info("Provider package '$prebuiltSoProvidersPackageName' is not supported, skipping pickFirsts configuration.")
logger.info("Provider package '$prebuiltSoProvidersPackageName' is not in the project, skipping pickFirsts configuration.")
return@forEach
}
logger.info("Provider package '$prebuiltSoProvidersPackageName' is supported, configuring pickFirsts for '$nativeLibName'.")
architectures.forEach { arch ->
androidExtension.packagingOptions.jniLibs.pickFirsts
.add("lib/$arch/$nativeLibName")
}
logger.info(
"Provider package '$prebuiltSoProvidersPackageName' is in the project, configuring pickFirsts for '$nativeLibName'.",
)
androidExtension.packagingOptions.jniLibs.pickFirsts
.add("lib/**/$nativeLibName")
}
}

Expand Down