Skip to content

Add maven url to gradle plugin#270

Draft
radoslawrolka wants to merge 3 commits intomainfrom
rolkrado/add-maven-to-gradle
Draft

Add maven url to gradle plugin#270
radoslawrolka wants to merge 3 commits intomainfrom
rolkrado/add-maven-to-gradle

Conversation

@radoslawrolka
Copy link
Collaborator

@radoslawrolka radoslawrolka commented Mar 3, 2026

📝 Description

  • bumped gradle & expo plugin versions
  • updated docs (removed mentions about adding allprojects {repositories { url ...}}}
  • updated tests
  • added project.uri("https://packages.rnrepo.org/releases") inside gradle plugin

🎯 Type of Change

  • ✨ New feature (non-breaking change which adds functionality)

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR centralizes RNRepo Maven repository configuration inside the Android Gradle plugin, and updates the Expo config plugin + docs to stop requiring manual allprojects { repositories { ... } } setup.

Changes:

  • Add RNRepo Maven repository registration to the PrebuildsPlugin at apply-time.
  • Remove allprojects Maven repo injection from the Expo config plugin and adjust its tests accordingly.
  • Update website/docs/READMEs to remove instructions for manually adding the RNRepo Maven repository.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 7 comments.

Show a summary per file
File Description
packages/website/src/components/GettingStarted.astro Updates Getting Started snippets to remove manual Maven repo setup.
packages/expo-config-plugin/src/withRNRepoPlugin.ts Removes the Android allprojects Maven repo injection mod.
packages/expo-config-plugin/tests/withRNRepoPlugin.test.ts Updates tests to no longer expect Maven repo injection.
packages/build-tools/package.json Bumps build-tools version and updates the packaged Gradle plugin jar filename.
packages/build-tools/gradle-plugin/src/main/kotlin/org/rnrepo/tools/prebuilds/PrebuildsPlugin.kt Adds addRNRepoRepository(project) to register the RNRepo Maven repository programmatically.
packages/build-tools/gradle-plugin/build.gradle Bumps Gradle plugin base version to 0.3.1.
packages/build-tools/README.md Removes manual Maven repo instructions from Android setup docs.
README.md Removes manual Maven repo instructions from the main Android setup docs.
Comments suppressed due to low confidence (1)

packages/build-tools/README.md:49

  • Same as the root README: removing the Maven repo instructions is fine when project repositories are allowed, but Gradle builds configured with RepositoriesMode.FAIL_ON_PROJECT_REPOS may still require adding the RNRepo repo under dependencyResolutionManagement in settings.gradle. Consider documenting that exception here to avoid setup failures that look like plugin bugs.
### Android Configuration

Add the following to your project's `android/build.gradle` file:

```diff
buildscript {
   dependencies {
      ...
+     def rnrepoDir = new File(
+       providers.exec {
+         workingDir(rootDir)
+         commandLine("node", "--print", "require.resolve('@rnrepo/build-tools/package.json')")
+       }.standardOutput.asText.get().trim()
+     ).getParentFile().absolutePath
+     classpath fileTree(dir: "${rnrepoDir}/gradle-plugin/build/libs", include: ["prebuilds-plugin-*.jar"])
   }
}

Then, apply the plugin in your android/app/build.gradle file:

apply plugin: "com.facebook.react"
+ apply plugin: "org.rnrepo.tools.prebuilds-plugin"
</details>



---

💡 <a href="/software-mansion/rnrepo/new/main?filename=.github/instructions/*.instructions.md" class="Link--inTextBlock" target="_blank" rel="noopener noreferrer">Add Copilot custom instructions</a> for smarter, more guided reviews. <a href="https://docs.github.com/en/copilot/customizing-copilot/adding-repository-custom-instructions-for-github-copilot" class="Link--inTextBlock" target="_blank" rel="noopener noreferrer">Learn how to get started</a>.

@radoslawrolka radoslawrolka marked this pull request as draft March 5, 2026 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants