WHIP output code restructuring - #2150
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors the WHIP output implementation by splitting responsibilities across dedicated modules (notably extracting the WhipOutput/init logic and stats sender into a new output.rs), while keeping the media streaming and track tasks in their existing modules.
Changes:
- Introduces
whip_output/mod.rsand a newwhip_output/output.rsto hostWhipOutput, init/wait logic,WhipClientTrack, andWhipOutputStatsSender. - Updates internal imports/visibility (
pub(super)+pubmethods) so sibling modules can access the moved types/functions. - Minor cleanup/fixups, including a spelling correction in
setup_track.rsand updatedPeerConnectionimport path.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| smelter-core/src/pipeline/webrtc/whip_output/track_task_video.rs | Updates WhipOutputStatsSender import path to new module location. |
| smelter-core/src/pipeline/webrtc/whip_output/track_task_audio.rs | Updates WhipOutputStatsSender import path to new module location. |
| smelter-core/src/pipeline/webrtc/whip_output/stream_media_to_peer.rs | Removes WhipOutput/stats/wait logic from this file; narrows imports and adjusts visibility for extracted components. |
| smelter-core/src/pipeline/webrtc/whip_output/setup_track.rs | Updates imports for moved types/handles; fixes a typo in a comment. |
| smelter-core/src/pipeline/webrtc/whip_output/output.rs | New module containing WhipOutput init, WhipClientTrack, stats sender, and deadline wait helper. |
| smelter-core/src/pipeline/webrtc/whip_output/mod.rs | New module root wiring up submodules and re-exporting WhipOutput. |
| smelter-core/src/pipeline/webrtc/whip_output/establish_peer_connection.rs | Updates PeerConnection import path to its module. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+63
to
+69
| match result { | ||
| Ok((task, handle)) => { | ||
| init_confirmation_sender.send(Ok(handle)).unwrap(); | ||
| task.run().await | ||
| } | ||
| Err(err) => init_confirmation_sender.send(Err(err)).unwrap(), | ||
| } |
wkozyra95
approved these changes
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.