Add VP8 decoder and VP8 RTP input#988
Merged
wkazmierczak merged 3 commits intomasterfrom Mar 14, 2025
Merged
Conversation
wkazmierczak
force-pushed
the
@wkazmierczak/add-vp8-to-decoder
branch
from
4cf0480 to
1771f7d
Compare
Closed
6 tasks
wkazmierczak
force-pushed
the
@wkazmierczak/add-vp8-to-decoder
branch
from
1771f7d to
02fff82
Compare
wkazmierczak
force-pushed
the
@wkazmierczak/add-vp8-to-decoder
branch
2 times, most recently
from
51d29ab to
a20ac49
Compare
wkazmierczak
force-pushed
the
@wkazmierczak/add-vp8-to-decoder
branch
from
a20ac49 to
0e1e13b
Compare
wkozyra95
approved these changes
Mar 12, 2025
| let kind = EncodedChunkKind::Video(VideoCodec::VP8); | ||
| let vp8_chunk = depayloader.depacketize(&packet.payload)?; | ||
|
|
||
| if vp8_chunk.is_empty() { |
Member
There was a problem hiding this comment.
are you sure that batching packets to construct entire frame is necessary for vp8? For h264 decoder needs to get all chunks for a frame at once, so something like this is necessary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.