Open
Conversation
Base automatically changed from
publish-on-crates-in-release-workflow
to
master
February 25, 2026 13:42
…l-sierra-compiler into release-script-and-guide
ddoktorski
reviewed
Mar 5, 2026
Contributor
ddoktorski
left a comment
ddoktorski
left a comment
There was a problem hiding this comment.
I'm not sure if we need an installation script in this case given that it's actually only required to update version in the Cargo.toml file
| rm Cargo.toml.bak 2> /dev/null | ||
|
|
||
| sed -i ".bak" "s@install.sh | sh -s -- v.*@install.sh | sh -s -- v${VERSION}@" README.md | ||
| rm README.md.bak 2> /dev/null |
Contributor
There was a problem hiding this comment.
In case of a stable release it'll update the README's installation command with the stable version, which leads to a confusion: we have "..run the following command with the requested prerelease version" but then show a stable version as the example. I suggest we remove that line entirely and keep 2.8.0-rc.0 as a static example that doesn't change with new releases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.