Skip to content

Conversation

chaimann
Copy link
Contributor

Summary

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

@github-actions github-actions bot added the changelog:repository Changes to the repository not within any gem label May 28, 2025
@chaimann
Copy link
Contributor Author

@tvdeyen should we do this to mitigate latest rubocop changes?

@chaimann
Copy link
Contributor Author

I can also start migrating to Standard Ruby in the meantime

@tvdeyen
Copy link
Member

tvdeyen commented May 28, 2025

I already started to migrate to standardrb. Will need to rebase my branch and can push it.

@codecov
Copy link

codecov bot commented May 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.64%. Comparing base (f55384c) to head (062043d).
Report is 21 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6239      +/-   ##
==========================================
- Coverage   88.83%   86.64%   -2.19%     
==========================================
  Files         850      520     -330     
  Lines       18328    11940    -6388     
==========================================
- Hits        16281    10345    -5936     
+ Misses       2047     1595     -452     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tvdeyen
Copy link
Member

tvdeyen commented May 28, 2025

@chaimann #6241

and @mamhoff also worked on #6240

@tvdeyen
Copy link
Member

tvdeyen commented May 29, 2025

I tend to move this in first, so we unblock other PRs. The work in #6240 and #6241 need way more time

@tvdeyen tvdeyen marked this pull request as ready for review May 29, 2025 08:49
@tvdeyen tvdeyen requested a review from a team as a code owner May 29, 2025 08:49
@tvdeyen tvdeyen merged commit df50e6a into solidusio:main May 29, 2025
23 of 24 checks passed
@tvdeyen tvdeyen added backport-v4.1 Backport this pull-request to v4.1 backport-v4.2 Backport this pull-request to v4.2 backport-v4.3 Backport this pull-request to v4.3 backport-v4.4 Backport this pull-request to v4.4 backport-v4.5 Backport this pull-request to v4.5 labels May 30, 2025
@github-actions
Copy link

💔 All backports failed

Status Branch Result
v4.1 Backport failed because of merge conflicts
v4.2 Backport failed because of merge conflicts
v4.3 Backport failed because of merge conflicts
v4.4 Backport failed because of merge conflicts
v4.5 An unhandled error occurred. Please see the logs for details

Manual backport

To create the backport manually run:

backport --pr 6239

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

@github-actions
Copy link

💔 Some backports could not be created

Status Branch Result
v4.1 Backport failed because of merge conflicts
v4.2 Backport failed because of merge conflicts
v4.3 Backport failed because of merge conflicts
v4.4 Backport failed because of merge conflicts
v4.5

Manual backport

To create the backport manually run:

backport --pr 6239

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

@github-actions
Copy link

💔 Some backports could not be created

Status Branch Result
v4.1 Backport failed because of merge conflicts
v4.2 Backport failed because of merge conflicts
v4.3 Backport failed because of merge conflicts
v4.4 Backport failed because of merge conflicts
v4.5

Manual backport

To create the backport manually run:

backport --pr 6239

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

@github-actions
Copy link

💔 Some backports could not be created

Status Branch Result
v4.1 Backport failed because of merge conflicts
v4.2 Backport failed because of merge conflicts
v4.3 Backport failed because of merge conflicts
v4.4 Backport failed because of merge conflicts
v4.5

Manual backport

To create the backport manually run:

backport --pr 6239

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

@github-actions
Copy link

💔 Some backports could not be created

Status Branch Result
v4.1 Backport failed because of merge conflicts
v4.2 Backport failed because of merge conflicts
v4.3 Backport failed because of merge conflicts
v4.4 Backport failed because of merge conflicts
v4.5

Manual backport

To create the backport manually run:

backport --pr 6239

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-v4.1 Backport this pull-request to v4.1 backport-v4.2 Backport this pull-request to v4.2 backport-v4.3 Backport this pull-request to v4.3 backport-v4.4 Backport this pull-request to v4.4 backport-v4.5 Backport this pull-request to v4.5 changelog:repository Changes to the repository not within any gem

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants