Skip to content

Show a non-empty chapter name for exception errors #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
cadx64 wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Show a non-empty chapter name for exception errors #27

cadx64 wants to merge 5 commits into from

Conversation

@cadx64
Copy link

@cadx64 cadx64 commented Dec 29, 2017

The first line of exceptions might be empty and an empty name will
be showed in the chapter. It's not good to know the actual error.

Add the check to use the first non-empty line instead as the chapter
name for exceptions.

@cadx64
Show a non-empty chapter name for exception errors
ae50f96 
The first line of exceptions might be empty and an empty name will
be showed in the chapter. It's not good to know the actual error.

Add the check to use the first non-empty line instead as the chapter
name for exceptions.
@cadx64
Copy link
Author

cadx64 commented Dec 29, 2017

A sample exception could be:

12-27 16:59:13.422 2663 2691 E BluetoothMap:
12-27 16:59:13.422 2663 2691 E BluetoothMap: java.lang.IllegalArgumentException: Service not registered: android.bluetooth.BluetoothMap$2@e66b16b
12-27 16:59:13.422 2663 2691 E BluetoothMap: at android.app.LoadedApk.forgetServiceDispatcher(LoadedApk.java:1044)
12-27 16:59:13.422 2663 2691 E BluetoothMap: at android.app.ContextImpl.unbindService(ContextImpl.java:1340)
12-27 16:59:13.422 2663 2691 E BluetoothMap: at android.content.ContextWrapper.unbindService(ContextWrapper.java:616)
12-27 16:59:13.422 2663 2691 E BluetoothMap: at android.bluetooth.BluetoothMap$1.onBluetoothStateChange(BluetoothMap.java:64)
12-27 16:59:13.422 2663 2691 E BluetoothMap: at android.bluetooth.IBluetoothStateChangeCallback$Stub.onTransact(IBluetoothStateChangeCallback.java:55)
12-27 16:59:13.422 2663 2691 E BluetoothMap: at android.os.Binder.execTransact(Binder.java:453)

The first line is an empty one and no name will be showed on the left error chapter.

@cadx64 cadx64 closed this Dec 29, 2017
@cadx64 cadx64 reopened this Dec 29, 2017
cadx64 added 4 commits January 16, 2018 22:56
@cadx64
Ignore the deprecated bugreport head
3d49fc8 
Android Nougat starts supporting bugreportz to generate zipped
bugreport files. bugreport will print the warning at the beginning.

The change recognizes the lines and ignore them, then handle the
file in the old way.
@cadx64
Return if the file is inexistent
7db4e16 
It includes the changes:

- Return not to print more errors if bugreport isn't existed
- Replace colon in the source file name to make bugreport work
  in windows/cygwin to handle zip files.
@cadx64
Support adb bugreport bugreport.zip
c2cc052 
A specific bugreport zip file will be generated and the change
can find out the bugreport file from main_entry.txt and only parse
it like other bugreport within a zip file.
@cadx64
Support "DUMPSYS MEMINFO"
3e0825d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@cadx64