Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #683 +/- ##
==========================================
- Coverage 80.48% 80.27% -0.21%
==========================================
Files 88 88
Lines 6158 6170 +12
==========================================
- Hits 4956 4953 -3
- Misses 1202 1217 +15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
These changes are all the easy ones where it is basically a swap out of the origin import Foundation, plus dropping the iso8601 dateformatter
a855c4d to
cc334c8
Compare
Member
Author
|
Oh this is going to be fun. Check out the dance that is needed to able to use FormatStyles from FoundationEssentials soto-core/Sources/SotoXML/XMLEncoder.swift Lines 541 to 551 in 58b5dc0 |
Not truly necessary but we can do it
0xTim
approved these changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes are all the easy ones where it is basically a swap out of the original import Foundation, plus dropping the iso8601 dateformatter
This is taking on the task @t089 started. This PR will include just the easy conversions first. I'll do others in separate PRs.