Rename TokenFileManager to LoginTokenManager#688
Merged
adam-fowler merged 1 commit intosoto-project:mainfrom Feb 23, 2026
Merged
Rename TokenFileManager to LoginTokenManager#688adam-fowler merged 1 commit intosoto-project:mainfrom
adam-fowler merged 1 commit intosoto-project:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #688 +/- ##
==========================================
- Coverage 80.34% 80.32% -0.02%
==========================================
Files 88 88
Lines 6170 6170
==========================================
- Hits 4957 4956 -1
- Misses 1213 1214 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Shoudl I care about the -0.02% reduced code coverage ? I don't see how renaming two files changes code coverage :-) |
Member
It might be a timing thing. I wouldn't worry |
adam-fowler
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small PR to prepare the future merge of #686
The SSO provider will introduce another
TokenManager. With this PR, we will haveLoginTokenManager. The SSO PR will add aSSOTokenManager