Skip to content

Rename TokenFileManager to LoginTokenManager#688

Merged
adam-fowler merged 1 commit intosoto-project:mainfrom
sebsto:sebsto/rename-token-file-manager
Feb 23, 2026
Merged

Rename TokenFileManager to LoginTokenManager#688
adam-fowler merged 1 commit intosoto-project:mainfrom
sebsto:sebsto/rename-token-file-manager

Conversation

@sebsto
Copy link
Contributor

@sebsto sebsto commented Feb 23, 2026

Small PR to prepare the future merge of #686
The SSO provider will introduce another TokenManager. With this PR, we will have LoginTokenManager. The SSO PR will add a SSOTokenManager

@codecov
Copy link

codecov bot commented Feb 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.32%. Comparing base (da0b8ba) to head (39088af).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #688      +/-   ##
==========================================
- Coverage   80.34%   80.32%   -0.02%     
==========================================
  Files          88       88              
  Lines        6170     6170              
==========================================
- Hits         4957     4956       -1     
- Misses       1213     1214       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sebsto
Copy link
Contributor Author

sebsto commented Feb 23, 2026

Shoudl I care about the -0.02% reduced code coverage ? I don't see how renaming two files changes code coverage :-)

@adam-fowler
Copy link
Member

Shoudl I care about the -0.02% reduced code coverage ? I don't see how renaming two files changes code coverage :-)

It might be a timing thing. I wouldn't worry

@adam-fowler adam-fowler merged commit a94a9cf into soto-project:main Feb 23, 2026
9 of 10 checks passed
@sebsto sebsto deleted the sebsto/rename-token-file-manager branch February 23, 2026 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants