Add Feature flag for language-directory #3316
Conversation
|
Yes, the Source Academy frontends should be configurable to provide a desired set of languages and their implementations. The purpose of the language directory is to provide a mapping from language names to the "official" x-slang implementations. What remains to be worked out is to configure what languages should be provided by sourceacademy.org and sourceacademy.nus.edu.sg and other frontends. Should that be done in a config file at build time, or should this also come from a github page? Any proposals? |
@martin-henz best to be done in a config file i think, less layers of indirection especially when setting up new frontends. |
Pull Request Test Coverage Report for Build 17429370465Details
💛 - Coveralls |
| @@ -41,6 +41,7 @@ | |||
| "@reduxjs/toolkit": "^1.9.7", | |||
| "@sentry/react": "^10.5.0", | |||
| "@sourceacademy/c-slang": "^1.0.21", | |||
| "@sourceacademy/language-directory": "https://github.com/loyaltypollution/language-directory.git#866cc934372a19e514af0025947ce7f1f5a6e1fc", | |||
There was a problem hiding this comment.
is it necessary for the language directory to point to your version?
|
|
||
| import { |
There was a problem hiding this comment.
not a review comment - this is beautiful. thanks!
| <ChapterSelectComponent | ||
| items={choices.filter(({ mainLanguage }) => mainLanguage === selectedLang)} | ||
| onItemSelect={handleChapterSelect} | ||
| itemRenderer={chapterRenderer(isFolderModeEnabled)} |
There was a problem hiding this comment.
is it right to say that folder mode will be disabled for the new evaluators for now? if so please doc it as a limitation
| import WorkspaceActions from 'src/commons/workspace/WorkspaceActions'; | ||
| import { playgroundConfigLanguage } from 'src/features/playground/PlaygroundActions'; | ||
|
|
||
| // TODO: Hardcoded to use the first sublanguage for each language |
| import LanguageDirectoryActions from 'src/features/languageDirectory/LanguageDirectoryActions'; | ||
| import type { ILanguageDefinition } from 'src/features/languageDirectory/LanguageDirectoryTypes'; | ||
|
|
||
| // Remove when conductors.languageDirectory is default behaviour |
There was a problem hiding this comment.
please mark this explicitly as a TODO, if possible with name and date as well
// TODO <name> <date>: Remove when conductors.languageDirectory is default behaviour| import LegacyNavigationBarLangSelectButton from './LegacyNavigationBarLangSelectButton'; | ||
|
|
||
| function useDirectoryOptions() { | ||
| const langs = useTypedSelector(s => s.languageDirectory.languages) as ILanguageDefinition[]; |
There was a problem hiding this comment.
correct me if i'm wrong, but i'm pretty sure you don't need this type assertation here
| }, [languagesLoaded, dispatch]); | ||
|
|
||
| const directoryEnabled = useFeature(flagLanguageDirectoryEnable); | ||
| if (!directoryEnabled) { |
There was a problem hiding this comment.
nit: this should be moved higher as a guard clause to cleanly separate logic. to my understanding the code above and below this correspond to the new Navigation bar lang select button, but this corresponds to the original button.
Simple proof-of-concept for adding additional languages via a
language-directory.To-Do?
Questions:
-slangvariants support conductors?Happy to collaborate with relevant people on making conductors first-class if that’s the direction we are taking 👍