Enable bugprone easily swappable parameters #1871
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Balakrishna Avulapati <[email protected]>
Signed-off-by: Balakrishna Avulapati <[email protected]>
Signed-off-by: Balakrishna Avulapati <[email protected]>
Signed-off-by: Balakrishna Avulapati <[email protected]>
Signed-off-by: Juan Cruz Viotti <[email protected]>
Signed-off-by: Balakrishna Avulapati <[email protected]>
Signed-off-by: Balakrishna Avulapati <[email protected]>
Signed-off-by: Balakrishna Avulapati <[email protected]>
Signed-off-by: Balakrishna Avulapati <[email protected]>
Signed-off-by: Balakrishna Avulapati <[email protected]>
Disabling `bugprone-easily-swappable-parameters` for now. We could skip exising usage and enable this in a separate PR. Signed-off-by: Balakrishna Avulapati <[email protected]>
Signed-off-by: Balakrishna Avulapati <[email protected]>
Signed-off-by: Balakrishna Avulapati <[email protected]>
Signed-off-by: Balakrishna Avulapati <[email protected]>
…lang-tidy-checks Signed-off-by: Balakrishna Avulapati <[email protected]>
This PR skips the check for existing usage, as fixing it can break the API. But this also makes sure that the new usage will be warned/signalled from now on. Signed-off-by: Balakrishna Avulapati <[email protected]>
|
Looks good, but conflicts once more! |
bavulapati
force-pushed
the
enable-bugprone-easily-swappable-parameters
branch
from
a038535 to
a8b59a6
Compare
|
@jviotti resolved conflict |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1761