Support returning pointers as part of SchemaTransformRule::Result

[jviotti]

Signed-off-by: Juan Cruz Viotti [email protected]

[github-actions]

Benchmark (macos/llvm)

Benchmark suite	Current: 1e1454a	Previous: 85b02e0	Ratio
Regex_Lower_S_Or_Upper_S_Asterisk	1.5816451737262462 ns/iter	1.623981381611628 ns/iter	0.97
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar	1.5667222534380285 ns/iter	1.571432752607895 ns/iter	1.00
Regex_Period_Asterisk	1.5679691611887634 ns/iter	1.5768688974216958 ns/iter	0.99
Regex_Group_Period_Asterisk_Group	1.5967844288128954 ns/iter	1.579226403342722 ns/iter	1.01
Regex_Period_Plus	1.8847324281792581 ns/iter	1.8928701600954607 ns/iter	1.00
Regex_Period	1.9010560239072927 ns/iter	2.026312048190365 ns/iter	0.94
Regex_Caret_Period_Plus_Dollar	1.9098755548229875 ns/iter	1.9880630275847122 ns/iter	0.96
Regex_Caret_Group_Period_Plus_Group_Dollar	1.8882624344367542 ns/iter	1.983145207552823 ns/iter	0.95
Regex_Caret_Period_Asterisk_Dollar	1.5824598384705988 ns/iter	1.6507183157268686 ns/iter	0.96
Regex_Caret_Group_Period_Asterisk_Group_Dollar	1.5763245782163493 ns/iter	1.65506875050554 ns/iter	0.95
Regex_Caret_X_Hyphen	6.574658610093575 ns/iter	6.942517948562242 ns/iter	0.95
Regex_Period_Md_Dollar	55.892602595940374 ns/iter	57.02822415832521 ns/iter	0.98
Regex_Caret_Slash_Period_Asterisk	5.144123115161385 ns/iter	5.007104160841558 ns/iter	1.03
Regex_Caret_Period_Range_Dollar	2.195958476075029 ns/iter	2.359109162709463 ns/iter	0.93
Regex_Nested_Backtrack	339.35577561804746 ns/iter	339.38876111545414 ns/iter	1.00
JSON_Array_Of_Objects_Unique	332.66840804466045 ns/iter	368.952843062667 ns/iter	0.90
JSON_Parse_1	20081.182747791197 ns/iter	22515.600635286777 ns/iter	0.89
JSON_Fast_Hash_Helm_Chart_Lock	48.2834439473056 ns/iter	54.73189525884967 ns/iter	0.88
JSON_Equality_Helm_Chart_Lock	121.43507289428955 ns/iter	133.52822597683195 ns/iter	0.91
JSON_String_Equal/10	5.968100939569003 ns/iter	6.363907391663935 ns/iter	0.94
JSON_String_Equal/100	5.638914688048025 ns/iter	6.036998528395424 ns/iter	0.93
JSON_String_Equal_Small_By_Perfect_Hash/10	0.313530269051777 ns/iter	0.3415266673548502 ns/iter	0.92
JSON_String_Equal_Small_By_Runtime_Perfect_Hash/10	3.0604437945920506 ns/iter	3.3537139020461595 ns/iter	0.91
JSON_String_Fast_Hash/10	1.5664325471450966 ns/iter	1.7288028991233824 ns/iter	0.91
JSON_String_Fast_Hash/100	1.8800990553998145 ns/iter	2.146381360822964 ns/iter	0.88
JSON_String_Key_Hash/10	1.2577961037239878 ns/iter	1.4761094199951 ns/iter	0.85
JSON_String_Key_Hash/100	1.9974171536673748 ns/iter	2.227438449521146 ns/iter	0.90
JSON_Object_Defines_Miss_Same_Length	2.5097994354069 ns/iter	2.81881241214031 ns/iter	0.89
JSON_Object_Defines_Miss_Too_Small	2.5324984491110487 ns/iter	2.7898316314628584 ns/iter	0.91
JSON_Object_Defines_Miss_Too_Large	2.5082743035470716 ns/iter	2.7963131398791616 ns/iter	0.90
Pointer_Object_Traverse	15.204969028939562 ns/iter	16.82535098555676 ns/iter	0.90
Pointer_Object_Try_Traverse	22.03310369516704 ns/iter	23.76023029253534 ns/iter	0.93
Pointer_Push_Back_Pointer_To_Weak_Pointer	143.00253495219096 ns/iter	159.12645860962226 ns/iter	0.90
Schema_Frame_OMC_Instances	141116175.00002468 ns/iter	147654925.0000062 ns/iter	0.96
Schema_Frame_OMC_References	80155817.62504098 ns/iter	73191560.22222413 ns/iter	1.10
Schema_Frame_OMC_Locations	76185286.99999338 ns/iter	69929045.79999503 ns/iter	1.09
Schema_Bundle_Meta_2020_12	3744368.1010825727 ns/iter	3756645.196807903 ns/iter	1.00

This comment was automatically generated by workflow using github-action-benchmark.

[github-actions]

Benchmark (linux/llvm)

Benchmark suite	Current: 1e1454a	Previous: 8e4f9f8	Ratio
Regex_Lower_S_Or_Upper_S_Asterisk	2.2171005832900255 ns/iter	2.2143837107748863 ns/iter	1.00
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar	2.2036338532796456 ns/iter	2.2105936819812464 ns/iter	1.00
Regex_Period_Asterisk	2.204788126055807 ns/iter	2.201242000911409 ns/iter	1.00
Regex_Group_Period_Asterisk_Group	2.2007807226211082 ns/iter	2.2078136444201943 ns/iter	1.00
Regex_Period_Plus	2.8054558129479927 ns/iter	2.7984855881927904 ns/iter	1.00
Regex_Period	2.579040268663143 ns/iter	2.7979349590542215 ns/iter	0.92
Regex_Caret_Period_Plus_Dollar	2.487931281655174 ns/iter	2.7995941720434434 ns/iter	0.89
Regex_Caret_Group_Period_Plus_Group_Dollar	2.4867329757444425 ns/iter	2.7987805780382438 ns/iter	0.89
Regex_Caret_Period_Asterisk_Dollar	2.4874758467094966 ns/iter	3.420167014992625 ns/iter	0.73
Regex_Caret_Group_Period_Asterisk_Group_Dollar	2.4869593903144125 ns/iter	3.418700924265283 ns/iter	0.73
Regex_Caret_X_Hyphen	12.592479579142175 ns/iter	13.072166205132705 ns/iter	0.96
Regex_Period_Md_Dollar	78.52347385618563 ns/iter	78.68777986157043 ns/iter	1.00
Regex_Caret_Slash_Period_Asterisk	5.903978923065037 ns/iter	6.842894618632831 ns/iter	0.86
Regex_Caret_Period_Range_Dollar	4.039378446597195 ns/iter	4.0423595793247005 ns/iter	1.00
Regex_Nested_Backtrack	497.10708748758736 ns/iter	505.0123707975723 ns/iter	0.98
JSON_Array_Of_Objects_Unique	400.31539203132974 ns/iter	397.2934935593789 ns/iter	1.01
JSON_Parse_1	28689.1155553727 ns/iter	28462.916256358098 ns/iter	1.01
JSON_Fast_Hash_Helm_Chart_Lock	56.25979893672408 ns/iter	55.88325778428968 ns/iter	1.01
JSON_Equality_Helm_Chart_Lock	154.94737007975655 ns/iter	154.98336478238005 ns/iter	1.00
JSON_String_Equal/10	6.225232955355395 ns/iter	6.2258551409070355 ns/iter	1.00
JSON_String_Equal/100	6.846160306433503 ns/iter	6.845950871359612 ns/iter	1.00
JSON_String_Equal_Small_By_Perfect_Hash/10	0.9347189351906001 ns/iter	0.9357365304702403 ns/iter	1.00
JSON_String_Equal_Small_By_Runtime_Perfect_Hash/10	14.7439196308262 ns/iter	14.612698450519446 ns/iter	1.01
JSON_String_Fast_Hash/10	2.4883208203038367 ns/iter	2.487649062841688 ns/iter	1.00
JSON_String_Fast_Hash/100	2.4856350899165784 ns/iter	2.4885509657690696 ns/iter	1.00
JSON_String_Key_Hash/10	2.684330051600581 ns/iter	2.651560401307685 ns/iter	1.01
JSON_String_Key_Hash/100	9.01848305200192 ns/iter	9.020185738945909 ns/iter	1.00
JSON_Object_Defines_Miss_Same_Length	3.731509958867798 ns/iter	3.7353943792779267 ns/iter	1.00
JSON_Object_Defines_Miss_Too_Small	3.7324386717775275 ns/iter	3.736581511226611 ns/iter	1.00
JSON_Object_Defines_Miss_Too_Large	3.7333075705585017 ns/iter	3.735992420299082 ns/iter	1.00
Pointer_Object_Traverse	46.06621581127144 ns/iter	46.05993128940751 ns/iter	1.00
Pointer_Object_Try_Traverse	53.2137756981363 ns/iter	53.240559364709625 ns/iter	1.00
Pointer_Push_Back_Pointer_To_Weak_Pointer	307.23294760734444 ns/iter	309.7165699797636 ns/iter	0.99
Schema_Frame_OMC_Instances	173133885.24999595 ns/iter	163246090.00000122 ns/iter	1.06
Schema_Frame_OMC_References	94377400.74999112 ns/iter	89088030.12499788 ns/iter	1.06
Schema_Frame_OMC_Locations	90345549.00000557 ns/iter	85966854.12500449 ns/iter	1.05
Schema_Bundle_Meta_2020_12	5390796.407695794 ns/iter	5323914.259839856 ns/iter	1.01

This comment was automatically generated by workflow using github-action-benchmark.

[github-actions]

Benchmark (windows/msvc)

Benchmark suite	Current: 1e1454a	Previous: 8e4f9f8	Ratio
Regex_Lower_S_Or_Upper_S_Asterisk	2.490017407935111 ns/iter	2.4825557142857435 ns/iter	1.00
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar	3.100950553882966 ns/iter	3.0958931298378483 ns/iter	1.00
Regex_Period_Asterisk	2.7972474094656543 ns/iter	2.790139820182787 ns/iter	1.00
Regex_Group_Period_Asterisk_Group	2.490023214285689 ns/iter	2.4846378571429084 ns/iter	1.00
Regex_Period_Plus	2.796520868038808 ns/iter	2.7905898201832766 ns/iter	1.00
Regex_Period	2.7933926773242925 ns/iter	2.793732989824149 ns/iter	1.00
Regex_Caret_Period_Plus_Dollar	2.793170891610026 ns/iter	2.789832855897619 ns/iter	1.00
Regex_Caret_Group_Period_Plus_Group_Dollar	2.790418659468495 ns/iter	2.8021166505346287 ns/iter	1.00
Regex_Caret_Period_Asterisk_Dollar	2.7887972519744486 ns/iter	2.795483570180613 ns/iter	1.00
Regex_Caret_Group_Period_Asterisk_Group_Dollar	2.4820650000001314 ns/iter	2.4787882142862014 ns/iter	1.00
Regex_Caret_X_Hyphen	5.908354464285789 ns/iter	5.9245598214273185 ns/iter	1.00
Regex_Period_Md_Dollar	140.2071365978864 ns/iter	139.43647145369212 ns/iter	1.01
Regex_Caret_Slash_Period_Asterisk	5.885789285714387 ns/iter	5.879495535712717 ns/iter	1.00
Regex_Caret_Period_Range_Dollar	3.1081570361059434 ns/iter	3.1046357142849548 ns/iter	1.00
Regex_Nested_Backtrack	593.675089285739 ns/iter	592.3953571429561 ns/iter	1.00
JSON_Array_Of_Objects_Unique	412.40797712462125 ns/iter	414.3682209950632 ns/iter	1.00
JSON_Parse_1	74057.13169641765 ns/iter	76663.81696428257 ns/iter	0.97
JSON_Fast_Hash_Helm_Chart_Lock	53.92856999999367 ns/iter	54.4143571428484 ns/iter	0.99
JSON_Equality_Helm_Chart_Lock	205.03337923953333 ns/iter	208.4099839995618 ns/iter	0.98
JSON_String_Equal/10	8.989526745581847 ns/iter	8.985099067028877 ns/iter	1.00
JSON_String_Equal/100	10.602489062499387 ns/iter	10.558743749999877 ns/iter	1.00
JSON_String_Equal_Small_By_Perfect_Hash/10	2.167861562499951 ns/iter	2.1655562500001224 ns/iter	1.00
JSON_String_Equal_Small_By_Runtime_Perfect_Hash/10	12.72930178571333 ns/iter	12.451653571425984 ns/iter	1.02
JSON_String_Fast_Hash/10	3.095049999999893 ns/iter	3.1248531250004214 ns/iter	0.99
JSON_String_Fast_Hash/100	3.097195933351586 ns/iter	3.135404910714052 ns/iter	0.99
JSON_String_Key_Hash/10	3.7239284540032473 ns/iter	3.7207600446428506 ns/iter	1.00
JSON_String_Key_Hash/100	13.605993019615537 ns/iter	16.400201899108552 ns/iter	0.83
JSON_Object_Defines_Miss_Same_Length	4.6442805907231035 ns/iter	4.643413403221455 ns/iter	1.00
JSON_Object_Defines_Miss_Too_Small	3.723663543288177 ns/iter	3.7203305968659905 ns/iter	1.00
JSON_Object_Defines_Miss_Too_Large	4.644259831794767 ns/iter	4.656844219789441 ns/iter	1.00
Pointer_Object_Traverse	54.261940000014874 ns/iter	54.26017857142743 ns/iter	1.00
Pointer_Object_Try_Traverse	72.057223214281 ns/iter	72.06854910712934 ns/iter	1.00
Pointer_Push_Back_Pointer_To_Weak_Pointer	161.13819196427974 ns/iter	176.37192475700854 ns/iter	0.91
Schema_Frame_OMC_Instances	395387649.9999751 ns/iter	400531349.9999375 ns/iter	0.99
Schema_Frame_OMC_References	242093566.66665372 ns/iter	245079466.66669038 ns/iter	0.99
Schema_Frame_OMC_Locations	232985833.33333528 ns/iter	235210533.33335355 ns/iter	0.99
Schema_Bundle_Meta_2020_12	13439254.000004439 ns/iter	13455621.999996765 ns/iter	1.00

This comment was automatically generated by workflow using github-action-benchmark.

[github-actions]

Benchmark (linux/gcc)

Benchmark suite	Current: 1e1454a	Previous: 8e4f9f8	Ratio
Schema_Frame_OMC_Instances	166808868.2500013 ns/iter	167578133.99999577 ns/iter	1.00
Schema_Frame_OMC_References	88397864.37499698 ns/iter	91344046.1250019 ns/iter	0.97
Schema_Frame_OMC_Locations	85824798.49999914 ns/iter	87762421.87499861 ns/iter	0.98
Schema_Bundle_Meta_2020_12	5440056.265616277 ns/iter	5420589.2834624695 ns/iter	1.00
Pointer_Object_Traverse	47.68354413568987 ns/iter	49.689193155759554 ns/iter	0.96
Pointer_Object_Try_Traverse	22.980435803270442 ns/iter	22.971407763169083 ns/iter	1.00
Pointer_Push_Back_Pointer_To_Weak_Pointer	170.67736486077 ns/iter	171.37032372637174 ns/iter	1.00
JSON_Array_Of_Objects_Unique	403.2310778873736 ns/iter	408.5123024641586 ns/iter	0.99
JSON_Parse_1	31806.572047225472 ns/iter	31615.346277583394 ns/iter	1.01
JSON_Fast_Hash_Helm_Chart_Lock	69.01804991784437 ns/iter	71.65265387533779 ns/iter	0.96
JSON_Equality_Helm_Chart_Lock	165.49105388650736 ns/iter	144.8673602096987 ns/iter	1.14
JSON_String_Equal/10	7.580554480419376 ns/iter	5.789496909788935 ns/iter	1.31
JSON_String_Equal/100	8.20664378862647 ns/iter	6.342571888476018 ns/iter	1.29
JSON_String_Equal_Small_By_Perfect_Hash/10	0.6259530382167903 ns/iter	0.9371875869200597 ns/iter	0.67
JSON_String_Equal_Small_By_Runtime_Perfect_Hash/10	25.792992258098856 ns/iter	19.601482271533595 ns/iter	1.32
JSON_String_Fast_Hash/10	0.9332731238115671 ns/iter	0.9324334271053165 ns/iter	1.00
JSON_String_Fast_Hash/100	0.9326232470898808 ns/iter	0.9322996650681882 ns/iter	1.00
JSON_String_Key_Hash/10	1.5568902279272252 ns/iter	1.2447284491530006 ns/iter	1.25
JSON_String_Key_Hash/100	12.432967532489531 ns/iter	12.431730144956932 ns/iter	1.00
JSON_Object_Defines_Miss_Same_Length	2.8020790137828073 ns/iter	2.4931322118635078 ns/iter	1.12
JSON_Object_Defines_Miss_Too_Small	2.487802831973203 ns/iter	2.797068333794534 ns/iter	0.89
JSON_Object_Defines_Miss_Too_Large	2.80258489700087 ns/iter	2.7981294966945423 ns/iter	1.00
Regex_Lower_S_Or_Upper_S_Asterisk	3.4241138020134256 ns/iter	3.419989070182382 ns/iter	1.00
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar	3.4203200215178065 ns/iter	3.4195175824121167 ns/iter	1.00
Regex_Period_Asterisk	3.4205267917827364 ns/iter	3.420406231190082 ns/iter	1.00
Regex_Group_Period_Asterisk_Group	3.41912547806583 ns/iter	3.418053376781516 ns/iter	1.00
Regex_Period_Plus	3.7318533336250073 ns/iter	3.729090783255107 ns/iter	1.00
Regex_Period	3.7322121131096346 ns/iter	3.730686699824358 ns/iter	1.00
Regex_Caret_Period_Plus_Dollar	3.7337196579510605 ns/iter	3.4227396136943575 ns/iter	1.09
Regex_Caret_Group_Period_Plus_Group_Dollar	3.734228905582086 ns/iter	3.41978510020143 ns/iter	1.09
Regex_Caret_Period_Asterisk_Dollar	4.663309773960039 ns/iter	3.7300047181413767 ns/iter	1.25
Regex_Caret_Group_Period_Asterisk_Group_Dollar	4.660923536649004 ns/iter	3.7311036415424925 ns/iter	1.25
Regex_Caret_X_Hyphen	13.697708657834939 ns/iter	13.078496081950266 ns/iter	1.05
Regex_Period_Md_Dollar	91.44272161795692 ns/iter	90.67066558691808 ns/iter	1.01
Regex_Caret_Slash_Period_Asterisk	9.647610095721404 ns/iter	8.390109726329406 ns/iter	1.15
Regex_Caret_Period_Range_Dollar	5.011581449126923 ns/iter	4.9731257247164775 ns/iter	1.01
Regex_Nested_Backtrack	825.0157852788934 ns/iter	819.3953173995128 ns/iter	1.01

This comment was automatically generated by workflow using github-action-benchmark.

[github-actions]

Benchmark (macos/gcc)

Benchmark suite	Current: 1e1454a	Previous: 8e4f9f8	Ratio
Regex_Lower_S_Or_Upper_S_Asterisk	2.3454556260898745 ns/iter	2.8159714210086024 ns/iter	0.83
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar	2.6086652948512135 ns/iter	3.0992111274790246 ns/iter	0.84
Regex_Period_Asterisk	2.122584988404806 ns/iter	2.5492066227620236 ns/iter	0.83
Regex_Group_Period_Asterisk_Group	2.037931818884072 ns/iter	2.414888656575341 ns/iter	0.84
Regex_Period_Plus	1.700279945738671 ns/iter	1.9654781250813727 ns/iter	0.87
Regex_Period	1.967969497469828 ns/iter	1.7834974950565794 ns/iter	1.10
Regex_Caret_Period_Plus_Dollar	1.9602702790961732 ns/iter	1.6873586159386669 ns/iter	1.16
Regex_Caret_Group_Period_Plus_Group_Dollar	1.7336885936499147 ns/iter	1.7326086603262594 ns/iter	1.00
Regex_Caret_Period_Asterisk_Dollar	2.0485088342360553 ns/iter	2.1722516486452292 ns/iter	0.94
Regex_Caret_Group_Period_Asterisk_Group_Dollar	2.0788230696571737 ns/iter	2.081487279560809 ns/iter	1.00
Regex_Caret_X_Hyphen	6.474338119593407 ns/iter	6.364503447342361 ns/iter	1.02
Regex_Period_Md_Dollar	75.64044143088941 ns/iter	75.21256941630686 ns/iter	1.01
Regex_Caret_Slash_Period_Asterisk	4.969678582666491 ns/iter	5.031689954299999 ns/iter	0.99
Regex_Caret_Period_Range_Dollar	2.221734332658891 ns/iter	2.0418341730720044 ns/iter	1.09
Regex_Nested_Backtrack	941.5382158664635 ns/iter	840.4200045428464 ns/iter	1.12
JSON_Array_Of_Objects_Unique	255.93801265220984 ns/iter	231.2818304343121 ns/iter	1.11
JSON_Parse_1	26338.578343458477 ns/iter	23897.67165485344 ns/iter	1.10
JSON_Fast_Hash_Helm_Chart_Lock	29.24892057474808 ns/iter	26.43991573719017 ns/iter	1.11
JSON_Equality_Helm_Chart_Lock	142.00670495925624 ns/iter	130.02384343351795 ns/iter	1.09
JSON_String_Equal/10	6.651500871636812 ns/iter	5.98560480429405 ns/iter	1.11
JSON_String_Equal/100	6.2977821286312405 ns/iter	5.601818705440271 ns/iter	1.12
JSON_String_Equal_Small_By_Perfect_Hash/10	0.9267519440924624 ns/iter	0.843938903974406 ns/iter	1.10
JSON_String_Equal_Small_By_Runtime_Perfect_Hash/10	4.125432477575307 ns/iter	3.816291961249702 ns/iter	1.08
JSON_String_Fast_Hash/10	2.262762518140904 ns/iter	2.059426799549089 ns/iter	1.10
JSON_String_Fast_Hash/100	2.0674132529509404 ns/iter	2.2320630007517823 ns/iter	0.93
JSON_String_Key_Hash/10	1.57696965104732 ns/iter	1.6841477792098405 ns/iter	0.94
JSON_String_Key_Hash/100	2.8124714382903804 ns/iter	2.8626570808139546 ns/iter	0.98
JSON_Object_Defines_Miss_Same_Length	1.975726435654578 ns/iter	1.949144108686192 ns/iter	1.01
JSON_Object_Defines_Miss_Too_Small	1.9728076268021169 ns/iter	1.9222771402305416 ns/iter	1.03
JSON_Object_Defines_Miss_Too_Large	1.9653258457411815 ns/iter	1.9233983532993097 ns/iter	1.02
Pointer_Object_Traverse	56.20255185461015 ns/iter	56.79413107383067 ns/iter	0.99
Pointer_Object_Try_Traverse	39.263100888716416 ns/iter	40.89198460594934 ns/iter	0.96
Pointer_Push_Back_Pointer_To_Weak_Pointer	165.11962869218365 ns/iter	170.66013187617048 ns/iter	0.97
Schema_Frame_OMC_Instances	166316509.24682617 ns/iter	156704962.25357056 ns/iter	1.06
Schema_Frame_OMC_References	83687126.63650513 ns/iter	82265274.8652867 ns/iter	1.02
Schema_Frame_OMC_Locations	90652121.43792047 ns/iter	81382698.48293728 ns/iter	1.11
Schema_Bundle_Meta_2020_12	4897991.8162028 ns/iter	4836585.951147612 ns/iter	1.01

This comment was automatically generated by workflow using github-action-benchmark.

[jviotti]

cc @Karan-Palan Take a look at this PR. It makes some small changes to how rules are created, so we can get better information out of the specific keywords that rules apply to. Previous rules are almost fully backwards compatible (with the exception that now rules cannot return strings), but if you use the new macros, then the runner gets more info :)