attempt of interface fix #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dunglas
reviewed
Feb 13, 2019
| @@ -116,9 +116,14 @@ public function getItemFromIri(string $iri, array $context = []) | |||
| /** | |||
| * {@inheritdoc} | |||
| */ | |||
| public function getIriFromItem($item, int $referenceType = UrlGeneratorInterface::ABS_PATH): string | |||
| public function getIriFromItem($item, int $referenceType = UrlGeneratorInterface::ABS_PATH/**, array $context = []**/): string | |||
There was a problem hiding this comment.
This class is final, so you can add the parameter. You should add a new ContextAwareDataConverterInterface however
soyuka
force-pushed
the
fix-interfaces
branch
from
9726c58 to
f1da0fe
Compare
soyuka
force-pushed
the
fix-interfaces
branch
from
f1da0fe to
2c160a7
Compare
soyuka
force-pushed
the
test-input-output
branch
14 times, most recently
from
0a6d61d to
d7885e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.