Open
Conversation
2 tasks
ZeWaka
reviewed
Sep 16, 2025
| namespace Robust.Shared.Maths.Colors; | ||
|
|
||
| /// <summary> | ||
| /// Represents a color with alpha in the sYCC colorspace. |
Contributor
Author
There was a problem hiding this comment.
parity with existing Color API, mostly.
Contributor
Author
|
I have now added |
|
👀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the colorspace-related APIs in
Coloris a mess, putting Linear sRGB values inColorand all other colorspaces just usingVector4without any safeguards against confusing, say, HSL for HSV. This PR adds theColorsnamespace, which holds actually typed color classes with methods for converting between them as appropriate.Opened as Draft because I want to add more features(mainly Oklab gamut clipping) and have colorspace parity with
Color, and then add deprecations to the existingColorcolorspace API while making them be wrappers over theColorsAPI.