Update PlacementManager::HandleRectRemoveReq#6403
Merged
PJB3005 merged 1 commit intospace-wizards:masterfrom Jan 30, 2026
Merged
Update PlacementManager::HandleRectRemoveReq#6403PJB3005 merged 1 commit intospace-wizards:masterfrom
PJB3005 merged 1 commit intospace-wizards:masterfrom
Conversation
* Fixed AGhost observers and player torsos getting deleted with rect delete.
PJB3005
approved these changes
Jan 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
With the currently in-engine method, rectangle delete DOES NOT delete actors, but DOES delete its children.
In Space-Station 14, this causes the torso, clothing, .etc to be deleted while the actor slowly suffocates. It also deletes AGhosts and turns them into "normal" observers with no Action UI elements.
This fixes that by checking if the component has a parent of an "Actor" (player component), and ignores it if so.
Not sure if there's a better way to handle this, so let me know if there is!
Note that the normal delete ignores this, and will still turn Actors into observers.