Skip to content

Comments

Fix resolve errors when networking EntityUids referencing deleted entities#6413

Closed
slarticodefast wants to merge 1 commit intospace-wizards:masterfrom
slarticodefast:fix-pvs-errors
Closed

Fix resolve errors when networking EntityUids referencing deleted entities#6413
slarticodefast wants to merge 1 commit intospace-wizards:masterfrom
slarticodefast:fix-pvs-errors

Conversation

@slarticodefast
Copy link
Member

@slarticodefast slarticodefast commented Feb 6, 2026

Another approach to the problem explained in #6152

This basically just disables the resolve error log. The component state is properly generated and networked regardless. If the referenced entity is deleted then GetNetEntity will return an invalid NetEntity which in turn is converted to an invalid EntityUid on the client, meaning that the server and client component state are the same after networking.

grafik

For testing:

  • Spawn a jukebox
  • Play a song and let it finish so that the audio entity gets deleted
  • Use the dirty console command to dirty the jukebox entity, which will network the reference to the deleted audio stream

Ideally this would be fixed with either WeakEntityReference or a relations system that automatically sets the datafields back to null when the entity is deleted. But this is causing an absolutely insane amount of over 24000 errors each day, which drowns out all other errors to the point that they become unusable and even cause lag spikes on the server. We even did not notice that admin logs were failing to save to the database for 2 weeks because no one saw the errors. And the discord relay notfying us about error spikes is constantly spamming us despite us adjusting the sensitivity multiple times, so no one even looks at it.

grafik

All PRs so far have been closed and I don't expect a new WeakEntityReference or relations system implementation any time soon, so I think this is a reasonable solution for the meantime to stop the error spam.

@Tayrtahn Tayrtahn added Priority: 1-Urgent GET ON IT STAT A: PVS / GameState Networking Related to GameState networking & PVS labels Feb 10, 2026
@PJB3005
Copy link
Member

PJB3005 commented Feb 17, 2026

This is just silencing an error. We don't want this.

@PJB3005 PJB3005 closed this Feb 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A: PVS / GameState Networking Related to GameState networking & PVS Priority: 1-Urgent GET ON IT STAT

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants