Send server URL when advertising#6416
Open
VasilisThePikachu wants to merge 1 commit intospace-wizards:masterfrom
Open
Send server URL when advertising#6416VasilisThePikachu wants to merge 1 commit intospace-wizards:masterfrom
VasilisThePikachu wants to merge 1 commit intospace-wizards:masterfrom
Conversation
VasilisThePikachu
requested review from
DrSmugleaf and
PJB3005
as code owners
PJB3005
requested changes
Feb 9, 2026
| @@ -51,7 +51,7 @@ public async void Start() | |||
| _sawmill.Info("hub.server_url unset. Trying to determine IP address automatically..."); | |||
| try | |||
| { | |||
| url = await GuessAddress(); | |||
| _cfg.SetCVar(CVars.HubServerUrl, url); | |||
Member
Author
There was a problem hiding this comment.
Please read my PR description
Member
There was a problem hiding this comment.
And... you're removing the guessing logic?
Member
Author
There was a problem hiding this comment.
Ok I am an idiot I see what this is about . Please be more verbose next time
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes the engine send out the servers current server URL when advertising.
This is intended for future additions to auth. Which include hub moderation and additions to helping with account recovery.
I am setting
hub.serverurlin the advertisement flow so that we can be sure we have some value set to use later. Also we probably should not query the ip service every time we try to advertise and should just "cache" it.