Fix: OccluderSystem ignored entity rotation when calculating AABB#6417
Closed
ThereDrD0 wants to merge 1 commit intospace-wizards:masterfrom
Closed
Fix: OccluderSystem ignored entity rotation when calculating AABB#6417ThereDrD0 wants to merge 1 commit intospace-wizards:masterfrom
OccluderSystem ignored entity rotation when calculating AABB#6417ThereDrD0 wants to merge 1 commit intospace-wizards:masterfrom
Conversation
Member
|
Multi-tile occluders cannot work with the current occlusion system. This PR doesn't work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Occluder system translated box2 but did not take into account entity rotation. This logic only works if the box is a square.
But if someone creates non-square box2 - any rotation breaks the logic.
I found this bug while debugging why people could see through my double airlocks.
Media
Before - a rotated double airlock with
boundingBox: "-0.5, -0.5, 1.5, 0.5"in Occluder is half "transparent"2026-02-09.04-08-41.mp4
After - you can't see through it anymore. Great!
2026-02-09.04-10-29.mp4
Double airlock prototype i used when recording videos.