Fix OnClientRequestFull throwing an error when trying to log data about a deleted entity#6420
Open
DrSmugleaf wants to merge 1 commit intospace-wizards:masterfrom
Open
Fix OnClientRequestFull throwing an error when trying to log data about a deleted entity#6420DrSmugleaf wants to merge 1 commit intospace-wizards:masterfrom
DrSmugleaf wants to merge 1 commit intospace-wizards:masterfrom
Conversation
…ut a deleted entity
moonheart08
reviewed
Feb 19, 2026
| sb.Append($"Client {session} requested full state on tick {tick}. Last Acked: {lastAcked}. Curtick: {_gameTiming.CurTick}."); | ||
|
|
||
| if (missingEntity != null) | ||
| if (missingEntity != null && TryGetEntityData(missingEntity.Value, out var uid, out _)) |
Contributor
There was a problem hiding this comment.
Should this not still log and just remark the entity doesn't exist? It likely existed previously.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Slightly suboptimal for the logging to be throwing an error for an error we are handling
The client also seemed to just get stuck forever waiting for better days