Skip to content

Belt fill changes, remove wrench whitelist#34618

Closed
K-Dynamic wants to merge 15 commits intospace-wizards:masterfrom
K-Dynamic:engineer-loadout
Closed

Belt fill changes, remove wrench whitelist#34618
K-Dynamic wants to merge 15 commits intospace-wizards:masterfrom
K-Dynamic:engineer-loadout

Conversation

@K-Dynamic
Copy link
Contributor

@K-Dynamic K-Dynamic commented Jan 24, 2025

About the PR

  • Replaced two explosive grenades inside grenadier rig to two shrapnel grenades and updated uplink description; now carries two explosive grenades, two shrapnel grenades, two syndicate minibombs, two EMP grenades
  • EMT belt starts with one extra ointment to match medical belt
  • Chef belt starts with a rolling pin and kitchen knife
  • Botanical belt starts with a hatchet, Plant-B-Gone spray bottle, and EZ nutrient chemistry bottle
  • Removed wrench whitelist from medical and janitor belts

Why / Balance

Changing the fills on belts reduces the time needed for crew to equip items and teaches players on what items to carry. Fills are job-specific and based on personal gameplay observations:

  • EMT belts are missing an ointment compared to medical belts
  • Botanists are missing a hatchet in their set of starting tools, a Plant-B-Gone to easily deal with kudzu, and an EZ nutrient bottle to go with their robust harvest

Grenadier rig was changed as it was in the same file as the rest of the belt fills. Shrapnel grenades should add to the variety of grenades inside the rig and make it more interesting to use.

Removed wrench whitelists since the special belts were intruding on utility belt functions.

Media

781953b
image

Grenadier rig

781953b
image

EMT belt

781953b
image

Chef belt

781953b
image

Botanical belt

781953b
image

Requirements

Changelog

🆑

  • tweak: Replaced two explosive grenades in grenadier rigs with shrapnel grenades, updated uplink description
  • tweak: EMT belts now start with an extra ointment to match medical belts
  • tweak: Chef belts now start with a rolling pin and kitchen knife
  • tweak: Botanical belts now start with a hatchet, Plant-B-Gone spray bottle, and EZ nutrient chemistry bottle
  • tweak: Janitor and medical belts no longer fit wrenches.

@github-actions github-actions bot added S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. size/XS Denotes a PR that changes 0-9 lines. size/S Denotes a PR that changes 10-99 lines. and removed size/XS Denotes a PR that changes 0-9 lines. labels Jan 24, 2025
@ArtisticRoomba ArtisticRoomba added P3: Standard Priority: Default priority for repository items. S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. T: Balance Change Type: Balance changes through direct value changes, or changes to mechanics that affect it DB: Beginner Friendly Difficulty: Great for beginners. Unambiguous in scope, and explains how to achieve the result. A: General Interactions Area: General in-game interactions that don't relate to another area. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Jan 24, 2025
@K-Dynamic K-Dynamic marked this pull request as draft January 30, 2025 01:48
@K-Dynamic
Copy link
Contributor Author

Drafting so I can make some more changes

@github-actions github-actions bot added size/M Denotes a PR that changes 100-999 lines. and removed size/S Denotes a PR that changes 10-99 lines. labels Feb 3, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Feb 3, 2025
@github-actions github-actions bot removed the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Feb 5, 2025
@BramvanZijp BramvanZijp added the S: Draft Status: This is a draft and might need to be retriaged upon opening. label Mar 1, 2025
@github-actions github-actions bot added the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Mar 23, 2025
@github-actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@K-Dynamic
Copy link
Contributor Author

I got no idea why I drafted this, it's basically ready for review I guess

@ArtisticRoomba ArtisticRoomba added S: Awaiting Changes Status: Changes are required before another review can happen and removed S: Draft Status: This is a draft and might need to be retriaged upon opening. S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. labels Apr 22, 2025
@ArtisticRoomba ArtisticRoomba self-assigned this Apr 22, 2025
@github-actions github-actions bot added size/S Denotes a PR that changes 10-99 lines. and removed size/M Denotes a PR that changes 100-999 lines. labels Apr 22, 2025
@github-actions github-actions bot added S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. and removed S: Awaiting Changes Status: Changes are required before another review can happen labels Apr 22, 2025
Copy link
Member

@Princess-Cheeseballs Princess-Cheeseballs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the whitelist expansions. I don't think body bags or bolas should fit in the belts, that's intentional design. Combat workgroup can disagree with me if they want on the bolas. Otherwise PR looks fine.

@PJBot PJBot added S: Awaiting Changes Status: Changes are required before another review can happen and removed S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. labels Oct 4, 2025
@github-actions github-actions bot added the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Oct 8, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 8, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@ArtisticRoomba
Copy link
Member

@K-Dynamic Still working on this?

@K-Dynamic
Copy link
Contributor Author

Yeah I didn't see the comment from last week, I'll push the changes later today

@github-actions github-actions bot removed the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Oct 10, 2025
@PJBot PJBot added S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. and removed S: Awaiting Changes Status: Changes are required before another review can happen labels Oct 10, 2025
@K-Dynamic K-Dynamic changed the title Belt fill changes Belt fill changes, remove wrench whitelist Oct 10, 2025
@github-actions github-actions bot added the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Nov 23, 2025
@github-actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@ArtisticRoomba
Copy link
Member

As of right now the PR is in a state of limbo. Maints aren't really accepting changing whats available roundstart until the roundstart equipment doc is merged (it's getting reviews). When that's merged this PR is just going to need to be redone so I'm just going to close this until we have it. Feel free to make change in-line with the doc once it's merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A: General Interactions Area: General in-game interactions that don't relate to another area. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. DB: Beginner Friendly Difficulty: Great for beginners. Unambiguous in scope, and explains how to achieve the result. P3: Standard Priority: Default priority for repository items. S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. size/S Denotes a PR that changes 10-99 lines. T: Balance Change Type: Balance changes through direct value changes, or changes to mechanics that affect it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants