Cleaned up contents of job lockers

[Hitlinemoss]

About the PR

Removes redundant/pointless items from job lockers, and reduces random variability of locker conents across the board. Retooled version of #38550.

Why / Balance

To my knowledge, maintainers' current stance on job lockers is that they should only contain job-essential equipment. To that end, having them sometimes roll for non-essential joke items causes them to be cluttered and makes that essential equipment harder to access. In addition, removing random variance for job-essential items makes equipping yourself with one of these lockers more consistent. I don't think these changes should have any significant impact on game balance, since any removed items should be easily accessible from other places in the department (usually vending machines or lathes).

Ideally, once these baseline changes are merged, I can work on a follow-up PR to more thoroughly clean up job lockers, wardrobe lockers, and wardrobe vendors; as it stands currently, job lockers often contain clothing (including headsets!) that really should just be put in a wardrobe for the sake of reducing clutter. (For some reason Medical has this problem the worst, to the point of even the CMO having articles of clothing in their locker despite having a dedicated dresser.) Naturally this would require making sure wardrobe vendors are actually mapped on all stations.

Technical details

YAML changes to the following prototypes:

LockerFillSalvageSpecialist:

• Now always spawns with two flares (previously 0-3 at random)

DresserHeadOfSecurityFilled:

• Now spawns with a neck gaiter (moved from HoS's locker)

LockerFillQuartermaster:

• No longer spawns with cigarettes (previously a 50% chance; if a QM character does not smoke this is useless, if a QM character smokes they will likely have cigarettes as a trinket anyway)

LockerFillCaptainNoLaser:

• No longer spawns with a premium cigar case (previously a 25% chance; if a Captain character does not smoke this is useless, if a Captain character smokes they will likely have some kind of smokables as a trinket anyway)
• No longer spawns with a nukie plushie (previously a 10% chance)

LockerFillHeadOfPersonnel:

• No longer spawns with a premium cigar case (previously a 25% chance; if a HoP character does not smoke this is useless, if a HoP character smokes they will likely have some kind of smokables as a trinket anyway)
• No longer spawns with an Ian backpack (previously a 50% chance; currently a loadout playtime reward so having it also spawn randomly in the locker is odd)

LockerFillChiefEngineerNoHardsuit:

• No longer spawns with a cigar case (previously a 15% chance; if a CE character does not smoke this is useless, if a QM character smokes they will likely have a cigar case as a trinket anyway)

LockerFillChiefMedicalOfficerNoHardsuit:

• No longer spawns with CMO's cloak or beret (these are already in the CMO's dresser)

LockerFillHeadOfSecurityNoHardsuit:

• No longer spawns with a premium cigar case (previously a 50% chance; if a HoS character does not smoke this is useless, if a HoS character smokes they will likely have some kind of smokables as a trinket anyway)
• No longer spawns with a neck gaiter (moved to HoS's dresser)

LockerFreezerVaultFilled

• Now spawns with a premium cigar case (the spawns from the Captain/HoP/HoS's lockers have been removed, so this was added as a guaranteed spawn to compensate)

LockerFillMedicalDoctor:

• No longer spawns with a health analyzer (previously a 60% chance)
• No longer spawns with a head mirror (previously a 10% chance)

LockerFillChemistry:

• Now always spawns with two beaker boxes (previously a 30% chance for the second)
• Now always spawns with a hand labeler (previously a 50% chance)

LockerFillParamedic:

• No longer has a chance to spawn with a medkit (previously a 30% chance; medbays generally have a whole back room where medical supplies are kept, so one random medkit in a job locker is unnecessary)

FillLockerScientist:

• Now always spawns with a network configurator (previously a 50% chance)

FillLockerSecurity:

• Now always spawns with a seclite (previously an 80% chance)
• Now always spawns with a flash (previously a 50% chance)
• Now always spawns with a Space Law book (previously a 50% chance)
• No longer has a chance to spawn with a grey security jumpsuit (previously a 30% chance)
• No longer has a chance to spawn with a holoprojector (previously a 60% chance; the security belt already contains one)
• No longer has a chance to spawn with an anti-inflatable armament (previously a 10% chance)

FillLockerBooze:

• Now always contains exactly one box of beanbag shells and exactly two bar rags (previously had one of each or two of one at random. I think? I don't know exactly what !type:AllSelector did here.)

FillLockerBotanist:

• Now always spawns with a robust harvest bottle (previously a 30% chance)
• No longer spawns with a trucker hat (previously a 10% chance)

FillWardrobeScience:

• No longer spawns with glasses (previously a 50% chance)
• No longer spawns with a crowbar (previously a 10% chance; Half-Life reference is funny, but I'm trying to reduce item clutter regardless)

FillWardrobeMedicalDoctor:

• No longer spawns with glasses (previously a 30% chance)
• Now always spawns with latex gloves (previously a 40% chance)

Media

Purely YAML changes, no media needed.

Requirements

• I have read and am following the Pull Request and Changelog Guidelines.
• I have added media to this PR or it does not require an ingame showcase.

Breaking changes

N/A

Changelog

🆑

• tweak: Most job lockers have been adjusted to reduce clutter and variability.

[Entvari]

Some of these are a bit anti-fun.
Locker clutter seriously isn't that big of a deal and the occasional little rare joke like a crowbar in science equipment or a nukie plushie in the Captain locker are perfectly fine by my opinion.

Also I'd suggest making a secondary PR that increases/alters the stamp thief objective, while I like every head having approve/deny stamps, it'd make this objective very easy.

[FairlySadPanda]

This triage is a bit mental

Think this should be broken up by department, and the stamp change also broken out.

[Hitlinemoss]

Think this should be broken up by department,

These are a lot of individual small changes (most lockers only have 1-2 things adjusted, most departments only have 2-3 lockers affected), so that would be obnoxious because we'd have like five entirely independent PRs to remove smokables from heads' lockers.

and the stamp change also broken out.

Yeah sure. The author of #39868 mentioned on discord that I should probably put the stamps inside of a stamp box of some sort anyway (similarly to that PR's tote for circuit boards), which is probably a good idea.

[IProduceWidgets]

I agree some of the jokey stuff with low probs is probably fine. Makes the game seem a little more alive.

[IProduceWidgets]

I dunno this ones kinda funny, I don't think its hurting anything. Definitely a reminder / meme about captains being the center of nukie mode.

[Hitlinemoss]

The maintainer stance on job lockers (to my most recent current knowledge) is "should only contain the most essential job-related equipment" (see #37375 (comment)). I think this is especially important for heads' lockers, since they tend to be the most common targets of theft, so random clutter is undesirable.

[IProduceWidgets]

I suppose more beakers is fine. Kinda funny it made the chemists share though.
I would consider adding a second canister box since they are essentially expendable when handing them out.

[Hitlinemoss]

Adjusting the contents of lockers in a more-detailed balance-affecting way is beyond the scope of this PR (and why I closed the preceding PR), so adjusting chemistry lockers will come in a future PR.

[IProduceWidgets]

I dunno if we need 1 book per officer. The guidebook is always available.

[Hitlinemoss]

I think the book is valuable for newer players if only because A.) it immediately opens the right section of the guidebook, and B.) it provides an IC way for experienced players to tell cadets "read up on Space Law before you go out on patrol".

[IProduceWidgets]

Newer players can/must play the Cadet role, which has one in its loadout

[Hitlinemoss]

Regardless, I still think making the lockers a consistent source of a Space Law book is useful, if only because (to my knowledge) other sources of the book depend on random/map-specific spawns. I've had fun RP moments like "warden literally throws a Space Law book at the captain because they're repeatedly insisting in a sentence that's too high" and I want to encourage that sort of thing.

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[Hitlinemoss]

Made some tweaks to this PR. I think the only "open issues" now (assuming nothing I changed needs re-review) are the nukie plushie in the captain's locker and the Space Law books in the Security lockers.

[southbridge-fur]

Honestly I'm not a huge fan of how many percentage things have been changed to either guaranteed or removed entirely. I'd prefer those remain as I think they add a lot of variety to the game.

Edit: I am always someone who loves item clutter personally so I don't see it as a bad thing.

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[Hitlinemoss]

Honestly I'm not a huge fan of how many percentage things have been changed to either guaranteed or removed entirely. I'd prefer those remain as I think they add a lot of variety to the game.

In my eyes, randomized items aren't ideal for job lockers since they're intended to hold key job equipment, and should serve as a consistent baseline for what an individual player has access to at the start of their shift. For instance, I think that a random chance for security to not have seclites in the locker is kind of just a pointless inconvenience. Randomized departmental resources are probably better suited for map spawns (e.g, Cargo spawning with randomized crates in the cargo bay).

[Hrosts]

The linked judgement is on "common useful goods vs strictly needed items". This change primarily touches useless fluff items/variation, which aren't mentioned there. I'd like a separate opinion on this. +1 to the "this is anti-fun" crowd.

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[slarticodefast]

I'm putting DNM on this until we have decided on the loadout/locker/equipment guidelines here space-wizards/docs#524

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[Hitlinemoss]

Given this PR is effectively frozen until the roundstart-items design doc is finished I'm just going to mark it as a draft for now since I'm likely going to need to touch it up to fit said doc's design anyway.

[Hitlinemoss]

With the roundstart equipment design doc on the horizon, I'm going to close this PR since I think ideally I want to supersede it with a different, larger PR that touches on roundstart items more broadly (lockers, but also loadouts and vendors as well).